Buildbucket plugin: Check for Polymer inside Gerrit.install

Similar to https://crrev.com/c/874152.

This would allow Gerrit.install to be called in GWT UI,
which may prevent a "failed to load" error.
More context in https://crrev.com/c/862642.

Note, this is how it was before:
https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/df3692cd01780

Bug: gerrit:8142
Change-Id: I11cec77296758034d2da7ba4cbd8fee6164f83a4
Reviewed-on: https://chromium-review.googlesource.com/874291
Reviewed-by: jrn <jrn@google.com>
1 file changed
tree: 9a7f08cc8271c3da8f2736a3e048d7f521d46468
  1. src/
  2. test/
  3. .eslintrc.json
  4. .gitignore
  5. BUILD
  6. codereview.settings
  7. LICENSE
  8. README.md
  9. run-with-prod-data.sh
  10. wct.conf.json
README.md

Buildbucket Plugin for Gerrit

Usage

This plugin is configured via the buildbucket.config file present in the repo‘s refs/meta/config ref, as well as the same file in all repositories in the repo’s inheritance chain (up to and including All-Projects).

An example buildbucket.config is below:

[host]
  git = "chromium.googlesource.com"
  gerrit = "chromium-review.googlesource.com"

[bucket "chromium.buildbucket.swarming"]
  builder = infra_presubmit
  builder = infra_linux64
  builder = infra_mac
  builder = infra_win
[bucket "tryserver.infra"]
  builder = Infra Presubmit
  builder = Infra Linux Trusty 64 Tester
  builder = Infra Linux Precise 32 Tester
  builder = Infra Mac Tester
  builder = Infra Win Tester

In the vast majority of cases, the host.git and host.gerrit values are global to the entire host, so that stanza is specified in the All-Projects repo. Buckets and builders, on the other hand, are almost always very repository-specific, and so are only specified in “leaf” repositories which are not in any other repo's inheritance chain.

All changes to buildbucket.config files are instantly reflected. There is no caching period or need to restart the server.

Development

To use with the local testsite

ln -s /path/to/buildbucket-plugin plugins/buildbucket
bazel build plugins/buildbucket && \
  rm -rf ../gerrit_testsite/plugins/buildbucket.jar && \
  cp bazel-genfiles/plugins/buildbucket/buildbucket.jar ../gerrit_testsite/plugins/ && \
  ../gerrit_testsite/bin/gerrit.sh restart

To use with the polygerrit-ui server against live data

Use the script run-with-prod-data.sh; this creates a temporary directory with the plugin source in the expected layout and then invokes polygerrit-ui/run-server.sh. Example invocation:

GERRIT=~/gerrit ./run-with-prod-data.sh

Testing

# Install dependencies.
npm install -g bower
npm install -g web-component-tester
cd test/
bower install

# Run the tests from the directory root.
cd ../
wct

Note: Testing is disabled for Safari due to this issue.