commit | ee28e1bb29bf5e1f44903a2bf307ffdc513d6a26 | [log] [tgz] |
---|---|---|
author | Quinten Yearsley <qyearsley@chromium.org> | Fri Jan 12 22:49:08 2018 |
committer | Quinten Yearsley <qyearsley@chromium.org> | Tue Jan 16 17:01:23 2018 |
tree | 2c6f5866c546ec894e39c4b9c3ae25b6f71fdef1 | |
parent | 3a1dd11327211a3c4fd523c1f7c4e40b7ff17331 [diff] |
Buildbucket plugin: Remove unused _isSignedIn Context: An earlier CL (https://crrev.com/c/780460/) replaced usage of `_isSignedIn()` with `this.plugin.restApi().getLoggedIn()`, but didn't remove the method. I think it's unused now. Change-Id: If5633be239ff3cae2e7fc9a26dc5366e5267e408 Reviewed-on: https://chromium-review.googlesource.com/865644 Reviewed-by: Nodir Turakulov <nodir@chromium.org>
This plugin is configured via the buildbucket.config
file present in the repo‘s refs/meta/config
ref, as well as the same file in all repositories in the repo’s inheritance chain (up to and including All-Projects).
An example buildbucket.config is below:
[host] git = "chromium.googlesource.com" gerrit = "chromium-review.googlesource.com" [bucket "chromium.buildbucket.swarming"] builder = infra_presubmit builder = infra_linux64 builder = infra_mac builder = infra_win [bucket "tryserver.infra"] builder = Infra Presubmit builder = Infra Linux Trusty 64 Tester builder = Infra Linux Precise 32 Tester builder = Infra Mac Tester builder = Infra Win Tester
In the vast majority of cases, the host.git
and host.gerrit
values are global to the entire host, so that stanza is specified in the All-Projects repo. Buckets and builders, on the other hand, are almost always very repository-specific, and so are only specified in “leaf” repositories which are not in any other repo's inheritance chain.
All changes to buildbucket.config
files are instantly reflected. There is no caching period or need to restart the server.
ln -s /path/to/buildbucket-plugin plugins/buildbucket bazel build plugins/buildbucket && \ rm -rf ../gerrit_testsite/plugins/buildbucket.jar && \ cp bazel-genfiles/plugins/buildbucket/buildbucket.jar ../gerrit_testsite/plugins/ && \ ../gerrit_testsite/bin/gerrit.sh restart
Use the script run-with-prod-data.sh; this creates a temporary directory with the plugin source in the expected layout and then invokes polygerrit-ui/run-server.sh
. Example invocation:
GERRIT=~/gerrit ./run-with-prod-data.sh
# Install dependencies. npm install -g bower npm install -g web-component-tester cd test/ bower install # Run the tests from the directory root. cd ../ wct
Note: Testing is disabled for Safari due to this issue.