)]}' { "log": [ { "commit": "7a0234a43fe60973261ce62d74ff7703db554a97", "tree": "1346cc63842fa334ff3f49e277213a8c1ac84241", "parents": [ "fc05c408c57f9e25a8a6ac8dfef1a4efcc2e5051" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Thu Apr 09 21:59:47 2026" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Thu Apr 09 22:00:46 2026" }, "message": "Update Gerrit.styles mock\n\nRemove `icon` and add `material` to the `Gerrit.styles` mock to match\nthe updated `Styles` interface in Gerrit core.\n\nBug: 501154863\nChange-Id: I6694b4db05a56fd642e995ad47579230206edc6f\n" }, { "commit": "fc05c408c57f9e25a8a6ac8dfef1a4efcc2e5051", "tree": "3f00d7ecd818976a4926656636c7f0ff8d65beb3", "parents": [ "6ca999bbde8b10fec6b2b7092c736cbec34a96c4" ], "author": { "name": "Oliver Newman", "email": "olivernewman@google.com", "time": "Thu Apr 09 20:27:34 2026" }, "committer": { "name": "Oliver Newman", "email": "olivernewman@google.com", "time": "Thu Apr 09 20:28:20 2026" }, "message": "Fix \u0027Show All\u0027 button\n\nReplace @tap with @click in binary-size-table.ts. The @tap event handler\nwas not triggering in the newer version of Lit, preventing the button\nfrom expanding the table.\n\nChange-Id: I87d3598bf8d70316f338452d9b02b68e48d250e1\n" }, { "commit": "6ca999bbde8b10fec6b2b7092c736cbec34a96c4", "tree": "77dbd8d1d9fcd75a83840863b64734c0430a7a76", "parents": [ "336402fd5ff94be2064010e896c554cd14937e14" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Oct 08 18:38:17 2025" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Oct 08 18:38:17 2025" }, "message": "Fix local tests to use web_test_runner\n\nThese have been broken for a while since Gerrit removed karma\ntest runner.\n\nBug: 415387031\nChange-Id: I9283525a62d18864e076fd4e3009f5dbf3dc283b" }, { "commit": "336402fd5ff94be2064010e896c554cd14937e14", "tree": "a2dc82c2ef6a536fce16a12ac4d608976da6eb94", "parents": [ "a28003e886beaf3d4aa6f0c6290a2aaef4ae5cb9" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Jul 05 23:27:15 2023" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Jul 05 23:27:15 2023" }, "message": "Use check result to pass around data\n\nBug: 1459349, b/289433414\nChange-Id: I9f4f5f52591379842e3071353a0fab24989fb9dc" }, { "commit": "a28003e886beaf3d4aa6f0c6290a2aaef4ae5cb9", "tree": "4b76da12c475dd7cc39f4112f2f10ee2fb1c1982", "parents": [ "344baa27a8083dff8677736070bef9e12f2eb528" ], "author": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Thu Jun 29 22:43:05 2023" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Jun 29 22:43:05 2023" }, "message": "Reland \"Show newly added \"try\" rows\"\n\nThis reverts commit 344baa27a8083dff8677736070bef9e12f2eb528.\n\nReason for revert: Gerrit is having issues, this CL was not the issue\nas it hadn\u0027t been deployed. Relanding\n\nOriginal change\u0027s description:\n\u003e Revert \"Show newly added \"try\" rows\"\n\u003e\n\u003e This reverts commit 43780ea9a52bb70f125952309de191e52070769e.\n\u003e\n\u003e Reason for revert: Possibly breaking the binary size table expansion, reverting for now https://screenshot.googleplex.com/9vhAgEnuWos6HcN\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e Show newly added \"try\" rows\n\u003e \u003e\n\u003e \u003e Occasionally, new size buckets will be added in a CL, and reflected in\n\u003e \u003e the try build during presubmit. The processing logic would previously\n\u003e \u003e omit these rows from the table because the corresponding \"bucket\" would\n\u003e \u003e not be found in the CI build. This CL changes the logic to show the new\n\u003e \u003e size buckets as rows in the size table. The CI build will have a\n\u003e \u003e baseline size of 0.\n\u003e \u003e\n\u003e \u003e In the case of a new size bucket, even if the creep budget is exceeded,\n\u003e \u003e we will not raise a warning, since it\u0027s very normal that the initial\n\u003e \u003e size value would exceed the incremental value.\n\u003e \u003e\n\u003e \u003e Change-Id: I5b95f54b9522b05af15c6538eeb1af0cb62e42e6\n\u003e\n\u003e Change-Id: If0a8d58d7b8ab0fb46be8e4f21519b8a7aed204b\n\u003e No-Presubmit: true\n\u003e No-Tree-Checks: true\n\u003e No-Try: true\n\nChange-Id: I4ed866e0eb56bc6fc2235f02354c80a3ae580f13\n" }, { "commit": "344baa27a8083dff8677736070bef9e12f2eb528", "tree": "4995fcce9b762e77bd632836f0d8abff1d02dfdf", "parents": [ "43780ea9a52bb70f125952309de191e52070769e" ], "author": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Thu Jun 29 22:28:06 2023" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Jun 29 22:28:06 2023" }, "message": "Revert \"Show newly added \"try\" rows\"\n\nThis reverts commit 43780ea9a52bb70f125952309de191e52070769e.\n\nReason for revert: Possibly breaking the binary size table expansion, reverting for now https://screenshot.googleplex.com/9vhAgEnuWos6HcN\n\nOriginal change\u0027s description:\n\u003e Show newly added \"try\" rows\n\u003e\n\u003e Occasionally, new size buckets will be added in a CL, and reflected in\n\u003e the try build during presubmit. The processing logic would previously\n\u003e omit these rows from the table because the corresponding \"bucket\" would\n\u003e not be found in the CI build. This CL changes the logic to show the new\n\u003e size buckets as rows in the size table. The CI build will have a\n\u003e baseline size of 0.\n\u003e\n\u003e In the case of a new size bucket, even if the creep budget is exceeded,\n\u003e we will not raise a warning, since it\u0027s very normal that the initial\n\u003e size value would exceed the incremental value.\n\u003e\n\u003e Change-Id: I5b95f54b9522b05af15c6538eeb1af0cb62e42e6\n\nChange-Id: If0a8d58d7b8ab0fb46be8e4f21519b8a7aed204b\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\n" }, { "commit": "43780ea9a52bb70f125952309de191e52070769e", "tree": "4b76da12c475dd7cc39f4112f2f10ee2fb1c1982", "parents": [ "34b15b2afae8575dbacc13c9d6c76bbb8ba72af5" ], "author": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Fri Jun 23 22:54:04 2023" }, "committer": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Wed Jun 28 22:27:39 2023" }, "message": "Show newly added \"try\" rows\n\nOccasionally, new size buckets will be added in a CL, and reflected in\nthe try build during presubmit. The processing logic would previously\nomit these rows from the table because the corresponding \"bucket\" would\nnot be found in the CI build. This CL changes the logic to show the new\nsize buckets as rows in the size table. The CI build will have a\nbaseline size of 0.\n\nIn the case of a new size bucket, even if the creep budget is exceeded,\nwe will not raise a warning, since it\u0027s very normal that the initial\nsize value would exceed the incremental value.\n\nChange-Id: I5b95f54b9522b05af15c6538eeb1af0cb62e42e6\n" }, { "commit": "34b15b2afae8575dbacc13c9d6c76bbb8ba72af5", "tree": "4995fcce9b762e77bd632836f0d8abff1d02dfdf", "parents": [ "ffd84fcec77a859d5cba09c44e0a759f41b944c5" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Mon Apr 10 23:26:21 2023" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Mon Apr 10 23:26:21 2023" }, "message": "Handle case where last patchset is not autogenerated\n\ncomputeValidPatchNums mistakenly assumes that the last patchset in a\nsubmitted CL is always autogenerated and trivial.\n\nBug: 1431220\nChange-Id: Ic07118c4368be1826e10bd99d75bb1a41bd44e0d" }, { "commit": "ffd84fcec77a859d5cba09c44e0a759f41b944c5", "tree": "db176ef219eb617d004e6aba50d0aec5ad57d3d8", "parents": [ "36a44c56b68e931a74c5ef4c2fde6327be4bfbc3" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Sep 21 21:22:17 2022" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Sep 21 21:22:17 2022" }, "message": "Correctly call BuildbucketV2Client with a change number\n\nWithout a change number, the JWT request in buildbucket auth returns a\n404 so only public builds are queried. Include the change number so\nauth works.\n\nBug: 1366456\nChange-Id: I845d015bac6808069ba9d55c55dc5621e9a8ad29" }, { "commit": "36a44c56b68e931a74c5ef4c2fde6327be4bfbc3", "tree": "532c9f5a1c9684752784b362491439504fc59929", "parents": [ "3136972dbb86b15f29df06e4b947be1b90fab0cf" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Aug 31 22:40:45 2022" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Thu Sep 01 22:53:42 2022" }, "message": "Use @open-wc/testing and add Makefile\n\nBug: 1358229\nChange-Id: If5031aa82099dfe0570595905c5260960de8b9a3\n" }, { "commit": "3136972dbb86b15f29df06e4b947be1b90fab0cf", "tree": "798a57769200262d6f77f4e97da0fb7878c95884", "parents": [ "8539808e3c0636c4040d0a89d8634051e9bc5af0" ], "author": { "name": "Edwin Kempin", "email": "ekempin@google.com", "time": "Tue Mar 15 12:06:57 2022" }, "committer": { "name": "Edwin Kempin", "email": "ekempin@google.com", "time": "Tue Mar 15 12:08:44 2022" }, "message": "Use Flogger for writing logs\n\nUsing Flogger for logging is consistent with Gerrit core. Also Flogger\nhas a fluent API that is less error-prone and easier to read.\n\nSigned-off-by: Edwin Kempin \u003cekempin@google.com\u003e\nChange-Id: I71b6a2303d27d044bad1fb19b3636ff7ebf4b35d\n" }, { "commit": "8539808e3c0636c4040d0a89d8634051e9bc5af0", "tree": "0684c8a00c2b4e15095f7ed4b985f823a006fe8b", "parents": [ "03b86e6bda5b4cc6ab17242e585b5951953e9bb2" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Fri Feb 25 02:30:59 2022" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Fri Feb 25 02:30:59 2022" }, "message": "Remove a random console warning\n\nChange-Id: If31f1408ff89a25bca6da34e7643cd36c785ee3b" }, { "commit": "03b86e6bda5b4cc6ab17242e585b5951953e9bb2", "tree": "fa9efc8c015c3f96a05d0c1c8ef798b19cae1ec2", "parents": [ "9d55b60059b91d9812802d61915022ef6361694e" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Jan 12 20:07:10 2022" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Thu Feb 03 20:23:15 2022" }, "message": "Remove \u0027Binary size changes\u0027 panel\n\nThis CL makes the Checks tab the only way to view binary size changes.\n\nBug: 1228935\nChange-Id: I5b55fe9ff25160d7817cc25a2af6c72994a5dc8c\n" }, { "commit": "9d55b60059b91d9812802d61915022ef6361694e", "tree": "39c550cc0c2da3eadda1f2d68b9babff6d34e53d", "parents": [ "141f4015f65567e724f74a4249eb246ba7ce693c", "e382d5d29a7a7a6b05289c5863fab6a60ec1cde4" ], "author": { "name": "LUCI CQ", "email": "infra-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Feb 01 21:39:06 2022" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Feb 01 21:39:06 2022" }, "message": "Merge \"Use budgets and deltas to create check results\" into main" }, { "commit": "e382d5d29a7a7a6b05289c5863fab6a60ec1cde4", "tree": "9c173057cd9f310610fd8d63809a0f9cf18b99d4", "parents": [ "665c0c04d256f5502959b16afa7ea4e1b33ab147" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Tue Feb 01 01:39:38 2022" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Tue Feb 01 01:49:32 2022" }, "message": "Use budgets and deltas to create check results\n\nCurrently, the Check result is \"Binary Size Changes. Expand to view the\nchanges in binary sizes.\" This isn\u0027t particularly useful and the user\nis forced to click the panel to gain any information.\n\nThis CL reworks the result to better provide at-a-glance information.\n\nBug: 1228935\nChange-Id: I4916ea6485b3ac72275dbf5c585cc254c789dd5f\n" }, { "commit": "141f4015f65567e724f74a4249eb246ba7ce693c", "tree": "a78b1049282119fb3255e2fa4cfcb4bfc252d65d", "parents": [ "665c0c04d256f5502959b16afa7ea4e1b33ab147" ], "author": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Sat Jan 29 09:26:28 2022" }, "committer": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Sat Jan 29 09:26:28 2022" }, "message": "Use builderPair.ciBuilderGitHost override if specified\n\nBy default, pluginConfig.gitHost is used. However, if builderPair\nspecified a baseGitHost, override the default.\n\nBug: fuchsia:83734\nChange-Id: Ide6927ded4d137a15dc0817f13fe67521199fc1c\n" }, { "commit": "665c0c04d256f5502959b16afa7ea4e1b33ab147", "tree": "296cb1dd0459adeda4fc534b29b85beb6935c8fb", "parents": [ "bd8be427fb30a97f76f573a0854b0a11ebd6e0a7" ], "author": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Sat Jan 29 09:14:10 2022" }, "committer": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Sat Jan 29 09:14:10 2022" }, "message": "Add [builder].baseGitHost to plugin config\n\nThis is an optional field in the binary size plugin config for builder\nsections. The field is not currently respected by the plugin. This\nchange is split off from the logic change to the binary size plugin to\nbe safer, as the server-side change here is hard to test locally.\n\nTo set this field, a binary-size.config file should specify on a\nbuilder config:\n\n[builder \"luci.foo.bar/builder\"]\n ...\n baseGitHost \u003d \"foo.googlesource.com\"\n\nThe intended use of this field is to make it possible to override\nthe plugin\u0027s default [host].git value, which assumes that all builders\nshare the same git host. This is not true for Fuchsia.\n\nBug: fuchsia:83734\nChange-Id: Ib03de77c8be437f32c62c54f3027a53bd74ffdf6\n" }, { "commit": "bd8be427fb30a97f76f573a0854b0a11ebd6e0a7", "tree": "ff92834f4c49071c775c595e227e1bc893d944a7", "parents": [ "f5d2b1e8ef64f12e2448d6c6e986fc5964602ca7" ], "author": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Fri Jan 28 08:45:51 2022" }, "committer": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Sat Jan 29 01:09:01 2022" }, "message": "Collapse rows with no size delta by default\n\nA row will only be shown if (1) there is a size delta or (2) the row\u0027s\nbudget is exceeded. If neither of these conditions are met, the row is\nhidden by default.\n\nIf the \"Show All\" button is pressed, any hidden rows will be shown, and\nthe \"Show All\" button text will become \"Show Less\".\n\nIf the \"Show Less\" button is pressed, any rows that are hidden by\ndefault will be hidden again, and the \"Show Less\" button text will\nbecome \"Show All\" once more.\n\nNote that the button will never affect any rows which meet either of\nthe conditions (1) or (2).\n\nWebRTC example:\n\n- Without this CL: https://screenshot.googleplex.com/8bCk2qbxpJ3TsU7\n- With \u0026 collapsed: https://screenshot.googleplex.com/9AhUyiTZV3prfvz\n- With \u0026 expanded: https://screenshot.googleplex.com/C6u7z5hmmP9u8bq\n\nBug: fuchsia:92180\nChange-Id: I041747449687fd88550e618772c0cffa0749bfda\n" }, { "commit": "f5d2b1e8ef64f12e2448d6c6e986fc5964602ca7", "tree": "eeaede2b9c1c9a9eb571fad5a005a4846f00b404", "parents": [ "42ca11413cad60985d5eb3ed9cd379cd7b47e79f" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Mon Nov 22 23:20:13 2021" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Nov 24 22:39:21 2021" }, "message": "Convert to TypeScript and Lit\n\nBug: 1262258\nChange-Id: If90b42fa42fbce09e86c02e8e8dfbcaf6f54aa38\n" }, { "commit": "42ca11413cad60985d5eb3ed9cd379cd7b47e79f", "tree": "0eeeb69230eede71b2f7b58d0ede95585772c802", "parents": [ "d2a7b7d3524695b2e6c5acf4d96c6bd0ff1a239c" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Thu Nov 18 00:03:07 2021" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Nov 24 19:48:23 2021" }, "message": "Rename file extensions from js to ts\n\nBug: 1262258\nChange-Id: I60ada5604fc6942c076589d883f2625dbd73558d\n" }, { "commit": "d2a7b7d3524695b2e6c5acf4d96c6bd0ff1a239c", "tree": "5fd3c3134699b69912b7fbcc450cc89d127c4003", "parents": [ "e34a5b7e5c7d9a7c234ea1a21efe7d7914e45f5e" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Thu Nov 18 00:01:47 2021" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Nov 24 19:47:43 2021" }, "message": "Reformat code to match Gerrit plugins\n\nBug: 1262258\nChange-Id: I92102982c06d2bf7519516f923e61140fedfb8e7\n" }, { "commit": "e34a5b7e5c7d9a7c234ea1a21efe7d7914e45f5e", "tree": "f11688724b0277022caffca8ba7c4b6d390c00b3", "parents": [ "66f26efc2d3e2666c479c5aecb39a39e2260a8ab" ], "author": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Sat Oct 16 05:27:42 2021" }, "committer": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Mon Oct 18 05:43:47 2021" }, "message": "[binary-size] Add creepExemptionLabel to plugin config\n\nThis is an optional field in the binary size plugin config, which\ncurrently is not respected by the plugin. This change is split off from\nthe logic change to the binary size plugin to be safer, as the\nserver-side change here is hard to test locally.\n\nTo set this field, a binary-size.config file should specify:\n\n[labels]\n creepExemption \u003d \"Size-Review\"\n\nThe intention for this label is that, if a CL has a positive\n\"Size-Review\" vote, the plugin should downgrade the severity of a\ncreep budget error to a warning (and no longer block submission).\n\nBug: fuchsia:85953\nChange-Id: I4ce64efe0c5050baed7a01203e2e9724a30909a2\n" }, { "commit": "66f26efc2d3e2666c479c5aecb39a39e2260a8ab", "tree": "76e17bab5e9c526dce0ab9f3f1eecc8bd3704fbe", "parents": [ "0f49e6dcdf5a9da395790d6be6b1174cf5286630" ], "author": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Wed Oct 13 20:58:39 2021" }, "committer": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Wed Oct 13 21:59:07 2021" }, "message": "[binary-size] Refactor logic for exceeded budget(s)\n\nhttps://crrev.com/c/3203930 added logic to resolve exceeded creep\nbudgets as part of a bool in the \"binary size rows\" metadata. This\nchange refactors the logic for exceeded budgets to be consistent, such\nthat we don\u0027t resolve exceeded budget both in the core plugin JS code\nand on the frontend separately.\n\nTest: https://screenshot.googleplex.com/AfhQockcRxLnt5f shows the table\n after the change,\n https://screenshot.googleplex.com/7GuqxztUHu9mduE shows the table\n before the change. There is no visible change to the UI.\nBug: fuchsia:85126\nChange-Id: I5041c944ddbd196205166d8ba68c12829c424c5f\n" }, { "commit": "0f49e6dcdf5a9da395790d6be6b1174cf5286630", "tree": "9a27ba9907533daddafab76a1196450b3cb3adcc", "parents": [ "33625d43e3b40105c5cfcb49b3c3c2ddade38e0a" ], "author": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Mon Oct 04 22:20:32 2021" }, "committer": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Mon Oct 11 21:19:22 2021" }, "message": "[binary-size] Highlight any size delta which exceeds creep budget\n\nhttps://crrev.com/c/3199475 raised an overall Gerrit check WARNING if\nany creep budgets were exceeded. This change makes it such that the\n\"Size Delta\" in bytes (not the percentage) is highlighted in red for\nany row which exceeds its creep budget.\n\nThis helps the user more easily see which rows are offending rows rather\nthan needing to do eyeball comparisons between each size delta and creep\nbudget.\n\nFor builds which do not emit creep budgets, this has no functional\nchange.\n\nTest: https://screenshot.googleplex.com/4pRotGK3yBwuBuE shows absolute\n size deltas in red when they exceed the creep budget.\n https://screenshot.googleplex.com/3JEQKZkmLqiQEGp is how the\n size deltas look before this change.\nBug: fuchsia:85126\nChange-Id: I7b9393fc02734e92fbfffbad679ef79d426c170d\n" }, { "commit": "33625d43e3b40105c5cfcb49b3c3c2ddade38e0a", "tree": "9cc17986934330863582c78ec940ae07472c6957", "parents": [ "85268b08dc96ebfa450e8f2544bd4c0fde29b7a4" ], "author": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Fri Oct 08 21:05:09 2021" }, "committer": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Mon Oct 11 17:24:56 2021" }, "message": "[binary-size] Don\u0027t query for non-configured builders\n\nCurrently, the binary size plugin will query for builds in the try and\nci buckets, regardless of whether the builds are of builders in the\nplugin config.\n\nFurther processing by the plugin will filter out those builds from the\nbinary size rows, but NOT from being considered in the check\u0027s \"result\"\ni.e. INFO, WARNING, or ERROR.\n\nThis can result in the plugin seeing all SUCCESS builds for the\nbuilders in its config, but non-SUCCESS for builders not in its config,\nand so the check\u0027s \"result\" can mistakenly turn to ERROR. For Fuchsia,\nwe have some builders that emit binary size info, but are not\nproduction-ready and should be ignored by the plugin.\n\nThis change adds the configured builder names to the buildbucket search\nrequests, so that the ignored builds are never returned in the first\nplace. This fixes the above bug and makes the plugin query less data.\n\nTest: https://screenshot.googleplex.com/8fYKSxvVLA9UdzJ shows the\n incorrect ERROR without this change. After this change,\n https://screenshot.googleplex.com/72NFUaQKt9ir2KD shows the\n correct WARNING.\nBug: fuchsia:85126\nChange-Id: I8e248dfb520fb074530bf5d176ab02373d86decc\n" }, { "commit": "85268b08dc96ebfa450e8f2544bd4c0fde29b7a4", "tree": "19a8814226277ec27e8912a5af62992f70078948", "parents": [ "7c45bd2e9b456c68e5edcce236ccf5d6b37f97a0" ], "author": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Fri Oct 01 06:02:05 2021" }, "committer": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Fri Oct 01 23:22:33 2021" }, "message": "[binary-size] Raise WARNING if any creep budgets are exceeded\n\nThis change expands the criteria for the binary size plugin to raise a\nWARNING or higher. In order for the binary size plugin to raise INFO,\nall rows must be under absolute size budget AND all size deltas must be\nunder size creep budget.\n\nThis has no functional change for builds which don\u0027t emit size creep\nbudgets.\n\nBug: fuchsia:85126\nChange-Id: I8dbf071667412081b2e3be77d1be09eed870bc5d\n" }, { "commit": "7c45bd2e9b456c68e5edcce236ccf5d6b37f97a0", "tree": "df15aab295de7c258d09d86137be2614cb6fce56", "parents": [ "45547f739b43f93859a1fbb3c232097a2ab6f1ae" ], "author": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Fri Oct 01 02:55:25 2021" }, "committer": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Fri Oct 01 03:08:29 2021" }, "message": "[binary-size] Show \"Creep budget\" column\n\nThis change adds a \"Creep budget\" column to the binary size plugin,\nwhich is shown if one or more rows contain the \".creepBudget\" metadata\nin build.output.properties[\"binary_sizes\"]. If no rows contain the\n\".creepBudget\" metadata, then the column will not be displayed (there\nis no visible change to the UI for users who do not emit creep\nbudgets).\n\nIf the column is added, it is added to the right of the size delta\ncolumn.\n\nTest: https://screenshot.googleplex.com/7WJAohKiw4PWnCJ on a CL which\n emitted size creep budgets (the budgets were all set to 1024 KiB\n as a placeholder). Tested on another CL which does not emit size\n creep budgets https://screenshot.googleplex.com/6UnnKixFzaBZVEV\n to confirm that there is no change to the UI.\nBug: fuchsia:85126\nChange-Id: Ie4aff38a093c3f64f2fa6009f87b0fc2fa9db460\n" }, { "commit": "45547f739b43f93859a1fbb3c232097a2ab6f1ae", "tree": "49037e083e205723c35ac92a927c540c4e691f8d", "parents": [ "95597a37a904120445e3d6d639c8b7fa71d2a358" ], "author": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Wed Sep 22 18:16:04 2021" }, "committer": { "name": "Anthony Fandrianto", "email": "atyfto@google.com", "time": "Wed Sep 22 22:21:54 2021" }, "message": "[budgets] Do not treat \"creepBudget\" as a row entry\n\nSimilar to \".budget\" and \".owner\" entries, \".creepBudget\" is additional\nmetadata which should not be treated as its own row entry.\n\nTest: Locally confirmed that https://fxrev.dev/c/584177/6 had the\n creepBudget rows removed with this CL with Gerrit dev helper\n extension.\nBug: fuchsia:84845\nChange-Id: I1ea42052369038129e95f5b5604fe5c3b88047a6\n" }, { "commit": "95597a37a904120445e3d6d639c8b7fa71d2a358", "tree": "5b1dce133aa92b1f6a42b794af5698c9245f41f0", "parents": [ "a14c38aaf3760744db23adbf2ddffea7d182ba14" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Sep 08 22:44:04 2021" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Thu Sep 09 19:54:53 2021" }, "message": "Register checks only once\n\nGerrit requires that only one instance of checks is registered. This\nchange also fixes a bug where the binary size table in checks would not\nrefresh after changing pages.\n\nBug: 1228935\nChange-Id: I256deda49f4c0f33949eb4e7358618b7465366ec\n" }, { "commit": "a14c38aaf3760744db23adbf2ddffea7d182ba14", "tree": "325d258980d27d203f8495dec11e8a133b2549c0", "parents": [ "505b91b476f9367991e43074afee182b9ef5e88a" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Aug 11 23:45:20 2021" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Thu Aug 12 02:26:13 2021" }, "message": "Fix binary size checks displaying for the wrong patchset\n\nGerrit\u0027s \"Files\" and \"Checks\" tab have two separate patchset selectors.\nThe current code assumes these are equal but they are independent which\nresults in wrong Checks runs surfacing for a patchset.\n\nThis change fixes this issue and refactors code.\n\nChange-Id: Ib8cfc33ed33a3b7088d24834610a619168f4bd79\n" }, { "commit": "505b91b476f9367991e43074afee182b9ef5e88a", "tree": "ee8eaebc53f8dfb3416a5dbab1d0898c7a04abf9", "parents": [ "0e5bb9ce686afeafda2e2e57c6489e7b0a2515b3" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Jul 14 23:07:00 2021" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Mon Aug 09 21:45:46 2021" }, "message": "Use Checks to display binary-size-table-view\n\nCurrently, the binary size table is displayed only below the \"Files\",\n\"Comments\", etc. tabs. This change registers a Checks provider in the\nplugin to show the same table under the Checks tab if the user has\nopted in to Checks.\n\nBug: 1228935\nChange-Id: I1a44c0b9afdf356e69d744d0e166afff91142d3a\n" }, { "commit": "0e5bb9ce686afeafda2e2e57c6489e7b0a2515b3", "tree": "a50e232717b6b28789a67755bbc3d20f6ccd91bd", "parents": [ "6592f56da8d1699e2662dec9f0c28eb3791a8c0d" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Mon Jul 26 19:56:46 2021" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Mon Jul 26 19:56:46 2021" }, "message": "Fix withStatusCode return type\n\nwithStatusCode expects a BinarySizeConfig as its second argument, not a\nstring.\n\nBug: 1207374\nChange-Id: I2f70fb3e608919d45954f36556f563b8525606cf" }, { "commit": "6592f56da8d1699e2662dec9f0c28eb3791a8c0d", "tree": "6f61e32191fe20254c102e028f9b25ec639fc66c", "parents": [ "fa4d2db3bdc37be7e3b58e7096296952e846e508" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Jul 21 00:46:06 2021" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Jul 21 00:46:06 2021" }, "message": "Fix _getBuilds when handling empty batch response\n\nThe previous code assumed that an empty batch response has the field\n\u0027response\u0027, even though buildbucket returns {}.\n\nBug: 1231347\nChange-Id: I05f1a2de8e9c7e6f65c316acf890eb31ff8d0ef9" }, { "commit": "fa4d2db3bdc37be7e3b58e7096296952e846e508", "tree": "b8b8403bdcba6680eb60ee2ada286b7d7e1265f4", "parents": [ "66d3aca50e6821fde4c1700f6fa012c0a7cafe13" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Wed Jul 14 22:41:07 2021" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Thu Jul 15 18:00:41 2021" }, "message": "Decouple binary-size-view from binary-size-view-table\n\nThis change separates the plugin into two parts. One handles loading the\nplugin and fetching related data and the other handles rendering the\nbinary size table using the data. This change makes it easier for Checks\nintegration in the future.\n\nBug: 1228935\nChange-Id: Ice5be8ba9dda595f298949bbc2f5bca1c69b170c\n" }, { "commit": "66d3aca50e6821fde4c1700f6fa012c0a7cafe13", "tree": "757d932e65ff54f6b2984e01f26de304cd590c18", "parents": [ "d86094ead44dc2a07cbeaa026f591f39164111f0" ], "author": { "name": "Rob Mohr", "email": "mohrr@google.com", "time": "Thu Jul 08 16:10:48 2021" }, "committer": { "name": "Rob Mohr", "email": "mohrr@google.com", "time": "Thu Jul 08 16:13:39 2021" }, "message": "[readme] Add reference to `got_revision` property\n\nAdd information about the `got_revision` property to the README. Also\nupdate language in the Dependencies section.\n" }, { "commit": "d86094ead44dc2a07cbeaa026f591f39164111f0", "tree": "ac6456b2d1a9abcc657d7ac4502dd0638dba5369", "parents": [ "9d5eb672fbe164723afa07b4c3437d4e6dd5fcd2" ], "author": { "name": "Anthony Polito", "email": "apolito@google.com", "time": "Tue Jun 08 21:16:07 2021" }, "committer": { "name": "Anthony Polito", "email": "apolito@google.com", "time": "Tue Jun 08 21:16:07 2021" }, "message": "fix _selectRelevantBuilds and correct comment\nfix _binarySizeInfo tests\n\nSome tests still not fixed since they rely on buildbucket being installed.\n\nChange-Id: I7b3f110fa7bdd1a696072b893dde5dc4153fe5be" }, { "commit": "9d5eb672fbe164723afa07b4c3437d4e6dd5fcd2", "tree": "d7e536099d8441be2f9690da83cec6e6b73ee953", "parents": [ "5e5ccd322d7d3e5e914b48b87cd56368a22fce45" ], "author": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Thu May 27 22:28:45 2021" }, "committer": { "name": "Gavin Mak", "email": "gavinmak@google.com", "time": "Tue Jun 01 19:12:27 2021" }, "message": "Add package.json and use npm for wct tests\n\nThis change also re-enables tests. Since some tests are broken and\nothers obsolete, two tests are removed and one is fixed. The rest of\nthe failing tests are currently skipped.\n\nBug: 1201483, 1206464\nChange-Id: I663facde534bff59ff5871523d0214b16401c89e\n" }, { "commit": "5e5ccd322d7d3e5e914b48b87cd56368a22fce45", "tree": "6d04b4e8f892b22b487ca3895115a7a84afd0c26", "parents": [ "05f68a6778c7a9457045ddd57cc383a3040e04b5" ], "author": { "name": "Josip Sokcevic", "email": "sokcevic@google.com", "time": "Wed May 12 19:43:14 2021" }, "committer": { "name": "Josip Sokcevic", "email": "sokcevic@google.com", "time": "Wed May 12 19:43:14 2021" }, "message": "Check length of split string\n\nIf try or CI builders are misconfigured, plugin will raise\nArrayIndexOutOfBoundsException and return 500 error. Instead of that, we\nshould return actionable error message to user and return 409.\n\nR\u003dehmaldonado@google.com, ekempin@google.com\n\nBug: 1207374\nChange-Id: I6b6c073b282a64aab3f86cc8e00c8525d60050ff" }, { "commit": "05f68a6778c7a9457045ddd57cc383a3040e04b5", "tree": "c7bc3596fff8bd8fe3ebcb04e1cd72055ca49acf", "parents": [ "ee8a73e95b8753b2e46ac3b99f2bea8f95d7e2b2" ], "author": { "name": "Edward Lesmes", "email": "ehmaldonado@chromium.org", "time": "Tue Mar 09 23:35:08 2021" }, "committer": { "name": "Edward Lesmes", "email": "ehmaldonado@chromium.org", "time": "Tue Mar 09 23:35:51 2021" }, "message": "Add OWNERS\n\nChange-Id: I127cc1586ea85c878353fd6f961268e54d80ceb3\n" }, { "commit": "ee8a73e95b8753b2e46ac3b99f2bea8f95d7e2b2", "tree": "506e0cf7c7c22f6e9641a3ded3e16f32f0795245", "parents": [ "37e642e07a535938ec8027213575dbc40b4407f0" ], "author": { "name": "Todd Lee", "email": "leetodd@google.com", "time": "Fri Nov 13 02:39:47 2020" }, "committer": { "name": "Todd Lee", "email": "leetodd@google.com", "time": "Fri Nov 13 02:39:47 2020" }, "message": "[budgets] fix regression for size info with budgets\n\nThis change fixes an issue that arises when size info\ninputs for both ci \u0026 try builders contain budget info\nsuch as:\n\n{\n \"foo\" : 1024,\n \"foo.budget\": 1024,\n}\n\nresulting in the pluging rendering superfluous row elements\nrepresenting the budget items as binaries - e.g.\n\nhttps://screenshot.googleplex.com/9i7JhtftLRcyfu7.png\n\nThis only manifests when CI jobs include the budget info\n(recently merged).\n\nTo resolve this, we ensure that only the actual binary\nitems are counted as \u0027size\u0027 results (other info elements\nlike budget \u0026 owner being represented as associated properties\nwithin these) resulting in correct rendering - i.e\n\nhttps://screenshot.googleplex.com/59YbDcoNNqFJbfR.png\n\nAs part of this change, the _collateBinarySizeInfoFromBuildPairs\nmethod has also been refactored just to make clearer the fact\nthat these info items are not necessarily *just* binary sizes.\n\nFixes: fuchsia:64314\nChange-Id: I59b1de3319f0695ea689236180be19da1aae62f7\n" }, { "commit": "37e642e07a535938ec8027213575dbc40b4407f0", "tree": "1a23ac2a6dfc82b7e7b3cbde8ff36f12a041a5bd", "parents": [ "b357824f9ce68876c43aa65765a828e84358cc10" ], "author": { "name": "Todd Lee", "email": "leetodd@google.com", "time": "Thu Nov 05 21:43:23 2020" }, "committer": { "name": "Todd Lee", "email": "leetodd@google.com", "time": "Fri Nov 06 19:28:08 2020" }, "message": "[budgets] add budget/owner support for binary sizes\n\nThis change adds support for including optional\nbudget info from the binary_sizes dictionary.\n\nhttps://screenshot.googleplex.com/6HAix9d6ceZn7gY.png\n\nHere we extend the original dictionary format, which\nwas limited just binary name + size data of the form:\n\n{\n \"foo.so\": 1024,\n}\n\nTo now include budget \u0026 optional owner info of the form:\n\n{\n \"foo.so\": 1024,\n \"foo.so.budget\": 2048,\n \"foo.so.owner\": \"mailto:foo_owner@gmail.com\",\n}\n\nThe budget info is only shown in the UI when there is at\nleast one budget entry in the dictionary. The owner URL\n(when present) is a link that will be followed when the\nrespective budget value is clicked.\n\nThis change is backwards compatible with the original\nbinary-sizes dictionary format.\n\nBug: fuchsia:63619\n\nChange-Id: If64c57febd487685272e833fa04229b0a7b544aa\n" }, { "commit": "b357824f9ce68876c43aa65765a828e84358cc10", "tree": "9f5d7abaf7f544ee4b08901277fd89b4fba5142f", "parents": [ "ad41b8da0f154c98ba1264d66f98de0b4aa32283" ], "author": { "name": "Todd Lee", "email": "leetodd@google.com", "time": "Wed Nov 04 15:18:43 2020" }, "committer": { "name": "Todd Lee", "email": "leetodd@google.com", "time": "Wed Nov 04 15:32:55 2020" }, "message": "[theme] support gerrit dark theme\n\nupdate static html template to support variable styling\n\nlight: https://screenshot.googleplex.com/98VsP7HeTynBX2g.png\ndark: https://screenshot.googleplex.com/BvYcrQJFtWZtvYq.png\n\nFixes: go/fxb/62850\nChange-Id: I6a0cb5b905b2fb2a7159858fa8fb0b52fbd84603\n" }, { "commit": "ad41b8da0f154c98ba1264d66f98de0b4aa32283", "tree": "e8a70df6f3f736b687b4faa2fade57cee3dce672", "parents": [ "549e077a2c241880bcad97d88884749f131b4a27" ], "author": { "name": "Gary Miguel", "email": "garymm@google.com", "time": "Tue Nov 03 01:44:40 2020" }, "committer": { "name": "Gary Miguel", "email": "garymm@google.com", "time": "Tue Nov 03 01:44:40 2020" }, "message": "[readme] document how to test with Gerrit FE Dev Helper\n\nI found this quite useful when making changes recently.\n\nChange-Id: I16ccb273002220137c8442f6cac7c1429caeb1ad\n" }, { "commit": "549e077a2c241880bcad97d88884749f131b4a27", "tree": "048371cdc0e4169d25355ac22228b3e860dfb869", "parents": [ "ce82950b6d4113f3a90e28533ebb2abc160955f3" ], "author": { "name": "Gary Miguel", "email": "garymm@google.com", "time": "Mon Sep 28 17:30:49 2020" }, "committer": { "name": "Gary Miguel", "email": "garymm@google.com", "time": "Sat Oct 17 00:15:16 2020" }, "message": "Respect ciBuilderRepo field in the front-end.\n\nThis will let the plugin function when the base builder is\ntriggered by a different repo than the try builder. This is needed\nfor Fuchsia, where all CI builders are triggered by the integration\nrepo, but try builders are triggered by various repos.\n\nBug: fuchsia:60411\nChange-Id: Ie5528d361a6c1de390eeee5cf0c384d082fcaaff\n" }, { "commit": "ce82950b6d4113f3a90e28533ebb2abc160955f3", "tree": "ba47cce8bdfd426226a0a191d8be668418848b9e", "parents": [ "6086530bbfd71db6bab8a1dac3ea3482988e9736" ], "author": { "name": "Gary Miguel", "email": "garymm@google.com", "time": "Tue Sep 22 20:36:20 2020" }, "committer": { "name": "Gary Miguel", "email": "garymm@google.com", "time": "Mon Sep 28 17:28:00 2020" }, "message": "Support specifying builder.baseRepo.\n\nIn this change we only add support to the Java code to extract the\nnew configuration value and pass it to the JavaScript code.\n\nIn the next change, we\u0027ll add support to the JavaScript code to act on\nthis. Splitting it up because testing changes to both locally is\ndifficult and this seems less risky.\n\nBug: fuchsia:60411\nChange-Id: I75d6e92e70397798f6afd56ce01862c528b0081d\n" }, { "commit": "6086530bbfd71db6bab8a1dac3ea3482988e9736", "tree": "1a8cee295a56083988e43cf732f6aedba43253fc", "parents": [ "ebf359228a92e9068aec3967a91ebba174c79660" ], "author": { "name": "Mirko Bonadei", "email": "mbonadei@chromium.org", "time": "Mon Sep 14 13:08:56 2020" }, "committer": { "name": "Mirko Bonadei", "email": "mbonadei@chromium.org", "time": "Mon Sep 14 13:08:56 2020" }, "message": "Fix binary-size plugin (take 2).\n\nBug: webrtc:11890\nChange-Id: Ifc79ac241c78834d5329ce1611ab48f319ea3d05" }, { "commit": "ebf359228a92e9068aec3967a91ebba174c79660", "tree": "b3ea57be37a81d2b75aee1a89996d2c7d78b120f", "parents": [ "b434e1a7274e9c4e40fd237f115c2ebffac1b405" ], "author": { "name": "Mirko Bonadei", "email": "mbonadei@chromium.org", "time": "Mon Aug 31 12:45:59 2020" }, "committer": { "name": "Mirko Bonadei", "email": "mbonadei@chromium.org", "time": "Mon Aug 31 12:45:59 2020" }, "message": "Handle responses without \u0027builds\u0027.\n\nBug: webrtc:11890\nChange-Id: I87158a6167ee8953ad54867cf62b3f39c82ad17b" }, { "commit": "b434e1a7274e9c4e40fd237f115c2ebffac1b405", "tree": "6458a9646d8c4d415d384ebc38e505db1be945bf", "parents": [ "989a10027e0feede11d69f691526e9c1f681f1c2" ], "author": { "name": "Tao Zhou", "email": "taoalpha@google.com", "time": "Thu Jul 23 12:38:31 2020" }, "committer": { "name": "Tao Zhou", "email": "taoalpha@google.com", "time": "Thu Jul 23 12:38:36 2020" }, "message": "Replace @npm_bazel_rollup with @npm//@bazel/rollup\n\nThis is needed after we have rules_nodejs upgraded to 2.0\n\nRelated changes in gerrit core:\nhttps://gerrit-review.googlesource.com/q/topic:%22bump_rules_nodes_to_2.0.0%22\n\nChange-Id: I0a1ea471478089884c1ba106f36d4a6a626ffffe\n" }, { "commit": "989a10027e0feede11d69f691526e9c1f681f1c2", "tree": "93e834178500a887fb33d453093f25dd60a7290e", "parents": [ "c88e15b0d7f0e98a45555c5360351a97d6f120b2" ], "author": { "name": "David Pursehouse", "email": "dpursehouse@digital.ai", "time": "Tue Jun 23 23:25:27 2020" }, "committer": { "name": "David Pursehouse", "email": "dpursehouse@digital.ai", "time": "Tue Jun 23 23:25:27 2020" }, "message": "Format with google-java-format\n\nChange-Id: I23d7ebe2e603041e0a1cc161ec7dae889129bcfa\n" }, { "commit": "c88e15b0d7f0e98a45555c5360351a97d6f120b2", "tree": "1b408ddc33ff53423cc3a239df8ad7ed1a95e3f1", "parents": [ "7e6d911a0ba62c66edffe02694883b071005cd2b", "35ed811176de7df6b7d489e45e0d8c1343723ac3" ], "author": { "name": "Josip Sokcevic", "email": "sokcevic@google.com", "time": "Tue Jun 23 18:01:05 2020" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Jun 23 18:01:05 2020" }, "message": "Merge \"Use BuildBucketV2 client\"" }, { "commit": "35ed811176de7df6b7d489e45e0d8c1343723ac3", "tree": "de8fccfc12d1d182681dd94dab9d7e7f96372091", "parents": [ "1a40f92479f4cb3673cfb5687b8954db6bdb290e" ], "author": { "name": "Josip Sokcevic", "email": "sokcevic@google.com", "time": "Tue Jun 23 17:59:31 2020" }, "committer": { "name": "Josip Sokcevic", "email": "sokcevic@google.com", "time": "Tue Jun 23 17:59:31 2020" }, "message": "Use BuildBucketV2 client\n\nR\u003dehmaldonado@chromium.org\n\nBug: 1092698\nChange-Id: I44c20f02321a8b8adf40096c8081cf7dcde04e32" }, { "commit": "7e6d911a0ba62c66edffe02694883b071005cd2b", "tree": "e2c61428f1ada5b16d19c406d7bdcc50054ba8e8", "parents": [ "1a40f92479f4cb3673cfb5687b8954db6bdb290e" ], "author": { "name": "Josip Sokcevic", "email": "sokcevic@google.com", "time": "Mon Jun 15 16:59:07 2020" }, "committer": { "name": "Josip Sokcevic", "email": "sokcevic@google.com", "time": "Mon Jun 15 16:59:07 2020" }, "message": "Use binary-size.js instead of html\n\nBug: 1071896\nChange-Id: I73fe70af4d23606875a6149476ab450c2650314d" }, { "commit": "1a40f92479f4cb3673cfb5687b8954db6bdb290e", "tree": "cc4a4d07ce59dcc7215f851a19cb4bd092f25673", "parents": [ "28912ae3b2be02529cf081451efd593e8baae1bb" ], "author": { "name": "Josip Sokcevic", "email": "sokcevic@google.com", "time": "Mon Jun 15 16:57:34 2020" }, "committer": { "name": "Josip Sokcevic", "email": "sokcevic@google.com", "time": "Mon Jun 15 16:57:34 2020" }, "message": "Use polymer3\n\nBug: 1071896\nChange-Id: I260d59d60edf431d4bbcd4a404ff3efa18f86829" }, { "commit": "28912ae3b2be02529cf081451efd593e8baae1bb", "tree": "9db2cce0f08fa6748680c055e5f5fc9063b2abeb", "parents": [ "ce585c404fc3576fb1daf3dca4f9efb8c41c3eec", "b244068b4b72d53359e29c55a4c7158306bc4916" ], "author": { "name": "Edwin Kempin", "email": "ekempin@google.com", "time": "Thu Oct 17 11:59:55 2019" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Thu Oct 17 11:59:55 2019" }, "message": "Merge \"Replace bazel-genfiles with bazel-bin in run-with-testsite.sh\"" }, { "commit": "ce585c404fc3576fb1daf3dca4f9efb8c41c3eec", "tree": "46c9202bad3d031acd806424ff2a6eaa4135a582", "parents": [ "f5b6326488f0da33f8aa6293b5f0f5a10340cba2" ], "author": { "name": "David Pursehouse", "email": "dpursehouse@collab.net", "time": "Wed Oct 16 06:07:40 2019" }, "committer": { "name": "David Pursehouse", "email": "dpursehouse@collab.net", "time": "Wed Oct 16 06:07:40 2019" }, "message": "Remove bazel-genfiles from .gitignore\n\nChange-Id: I7776e1417d0a2979ff88d57ee04a3b474a4fb5d6\n" }, { "commit": "b244068b4b72d53359e29c55a4c7158306bc4916", "tree": "25305f7bbe602e33d565e00adc233d95eba95c88", "parents": [ "f5b6326488f0da33f8aa6293b5f0f5a10340cba2" ], "author": { "name": "David Pursehouse", "email": "dpursehouse@collab.net", "time": "Wed Oct 16 03:58:46 2019" }, "committer": { "name": "David Pursehouse", "email": "dpursehouse@collab.net", "time": "Wed Oct 16 03:58:46 2019" }, "message": "Replace bazel-genfiles with bazel-bin in run-with-testsite.sh\n\nBazel now generates its output in bazel-bin rather than\nbazel-genfiles.\n\nBug: Issue 11757\nChange-Id: I68902650c0aae85025016a59a65741f5f13f3637\n" }, { "commit": "f5b6326488f0da33f8aa6293b5f0f5a10340cba2", "tree": "854106d925ed786576aceae420f1a447df4519b9", "parents": [ "d607a029630508fae688bd5fcf553ef2060e99be" ], "author": { "name": "Edwin Kempin", "email": "ekempin@google.com", "time": "Fri Aug 02 13:58:29 2019" }, "committer": { "name": "Edwin Kempin", "email": "ekempin@google.com", "time": "Fri Aug 02 13:58:29 2019" }, "message": "Adapt to changed REST interfaces in Gerrit core\n\nSigned-off-by: Edwin Kempin \u003cekempin@google.com\u003e\nChange-Id: If8387294a1391cd3fa884361ee3e2414760adce4\n" }, { "commit": "d607a029630508fae688bd5fcf553ef2060e99be", "tree": "a76fed418f28d23998639bd2159af89f482f0a9e", "parents": [ "248122bf4166617cc22a82e093d62b6fa78f5a9a" ], "author": { "name": "Dave Borowitz", "email": "dborowitz@google.com", "time": "Fri Apr 12 21:22:11 2019" }, "committer": { "name": "Dave Borowitz", "email": "dborowitz@google.com", "time": "Fri Apr 12 21:22:11 2019" }, "message": "Format with google-java-format 1.7\n\nChange-Id: Ieddc9217effe22c8c954986eb23c3e345d065da0\n" }, { "commit": "248122bf4166617cc22a82e093d62b6fa78f5a9a", "tree": "53219236d73a4d0c07b46f3da4e1ea3a0358f44f", "parents": [ "09b840143d54f600bac4fac02a0a18fbb53f2d77" ], "author": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Thu Jan 10 15:17:39 2019" }, "committer": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Thu Jan 10 17:38:41 2019" }, "message": "Update for compatibility with changes in Buildbucket plugin\n\nhttps://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/ab3014c..b1dd8c8/src/main/resources/static/cr-buildbucket-view.js\n\nBug: chromium:920606\nChange-Id: I8d65e1b07f1091ea18bf229c3e9a4c736776a7e9\n" }, { "commit": "09b840143d54f600bac4fac02a0a18fbb53f2d77", "tree": "52d9def6c271c0f828c5860b9664a4f983077a81", "parents": [ "2a204836cc7c3e659f8ebdbbca0eaea78a466dad" ], "author": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Sun Jun 03 18:23:10 2018" }, "committer": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Sun Jun 03 18:23:10 2018" }, "message": "Update instructions\n\nChange-Id: Ic06ca33f07932a0bcc7100537208441ede795b78" }, { "commit": "2a204836cc7c3e659f8ebdbbca0eaea78a466dad", "tree": "0b84edea46250518e2c1355f962e5678116d92ef", "parents": [ "5e68af19dc9342dee9578241bf93216dec17082c" ], "author": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Mon May 28 06:00:20 2018" }, "committer": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Mon May 28 06:00:20 2018" }, "message": "Implicitly depend on cr-buildbucket-client without copying files\n\nBug: webrtc:9205\nChange-Id: I2119f750d1eed6ce30c83fa3da0689dde3c88ba8" }, { "commit": "5e68af19dc9342dee9578241bf93216dec17082c", "tree": "03edfd90c17d913fd2172c78ee863a13993f1d90", "parents": [ "19b01f69a60b2a67ac552bb71c318e8e08a23621" ], "author": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Mon May 28 06:00:01 2018" }, "committer": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Mon May 28 06:00:01 2018" }, "message": "Rearrange files to make the plugin more easily testable\n\nChange-Id: Ic71f872667cf87128f0712b75b8db3d19ec85715" }, { "commit": "19b01f69a60b2a67ac552bb71c318e8e08a23621", "tree": "585bbe530d3ebea4f3616bda327f2f9603846f2a", "parents": [ "7315d2cdea8961b25e6ea518c3b3b9ac76543f26" ], "author": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Mon May 28 05:59:52 2018" }, "committer": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Mon May 28 05:59:52 2018" }, "message": "Add a column with delta percentage\n\nBug: webrtc:9205\nChange-Id: I53be69c7779c3b7764859c3f5fa06d2621b02961" }, { "commit": "7315d2cdea8961b25e6ea518c3b3b9ac76543f26", "tree": "f857bd2c74e50cb064b85617c4b2501074ea3d6f", "parents": [ "474890b2e76a090e58dc2ad4f9dab6dcd6eee504" ], "author": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Mon May 28 05:59:40 2018" }, "committer": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Mon May 28 05:59:40 2018" }, "message": "Lint fixes\n\nChange-Id: Ia18fb6aeb5618d8bcec3b77e7ff84d0123698523" }, { "commit": "474890b2e76a090e58dc2ad4f9dab6dcd6eee504", "tree": "55c9c939fab68b74563aba144f614be8ea8d2cf8", "parents": [ "1830160aedc1b0371e09c5c45ad90ce9ea2c1e4a" ], "author": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Fri May 11 07:04:55 2018" }, "committer": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Fri May 11 07:04:55 2018" }, "message": "Lint fixes\n\nBug: None\nChange-Id: Ie52e04b9c2c01aa9c268b8455bc9a3698caf57fc" }, { "commit": "1830160aedc1b0371e09c5c45ad90ce9ea2c1e4a", "tree": "fbbde9c15e4e2228c28433b70ab1ac40096753fc", "parents": [ "abec7a4d33f2b0b11a8b89192bc1963d7e1d40bc" ], "author": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Wed May 09 10:29:01 2018" }, "committer": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Wed May 09 10:29:01 2018" }, "message": "Implement binary-size plugin\n\nBug: webrtc:9205\nChange-Id: Ie5bb5d55ff990fcdf05be8b24c32a8ec4860bf6b" }, { "commit": "abec7a4d33f2b0b11a8b89192bc1963d7e1d40bc", "tree": "c47d1693c9953eb09ebd7e4291604f85e4ce5ec4", "parents": [ "0c47b9c2aaec78387260862b755a09a1d6d7a196" ], "author": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Wed May 09 07:52:37 2018" }, "committer": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Wed May 09 07:52:37 2018" }, "message": "Adjust JS lint settings\n\nBug: webrtc:9205\nChange-Id: I1c56470613b5fc0be6565b5123f8f6d262b22cdc" }, { "commit": "0c47b9c2aaec78387260862b755a09a1d6d7a196", "tree": "5e76ba258a4449da6fd276c2ead04675f9044293", "parents": [ "dbced2782b4b6128054d176fd9720435d8950d3b" ], "author": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Wed May 09 07:52:31 2018" }, "committer": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Wed May 09 07:52:31 2018" }, "message": "Integrate cr-build-block into the main view, remove grouping\n\nBug: webrtc:9205\nChange-Id: I93d70665176b8f5467d913c45853dd92e4e6dddd" }, { "commit": "dbced2782b4b6128054d176fd9720435d8950d3b", "tree": "0da8da01da1c2ec4a0c870775f3277f404b91c11", "parents": [ "fb2d17d22983a2e829af57c1b0bdbf77fa1f4801" ], "author": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Wed May 09 07:52:26 2018" }, "committer": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Wed May 09 07:52:26 2018" }, "message": "Remove tryjob picker and luci-chip\n\nBug: webrtc:9205\nChange-Id: If4cc8b84bdafacdf2c94350395e1b9e94488d8ba" }, { "commit": "fb2d17d22983a2e829af57c1b0bdbf77fa1f4801", "tree": "9649737402f871591e39b9557c53c49548e8de6b", "parents": [ "dd84e590c00414d26a42f50e5c04e1d94ee992c0" ], "author": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Wed May 09 07:52:21 2018" }, "committer": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Wed May 09 07:52:21 2018" }, "message": "Remove buildbucket-specific tests\n\nBug: webrtc:9205\nChange-Id: Ib5cf6a67ed2182c17e041ebe3a59500bec042844" }, { "commit": "dd84e590c00414d26a42f50e5c04e1d94ee992c0", "tree": "b92f063d12296582a176311e08f93c7ec3239a8d", "parents": [ "07639d05f0f4ddd25d3ace0d256b98e1d5900130" ], "author": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Wed May 09 07:51:42 2018" }, "committer": { "name": "Oleh Prypin", "email": "oprypin@webrtc.org", "time": "Wed May 09 07:51:42 2018" }, "message": "Rename buildbucket -\u003e binary-size\n\nBug: webrtc:9205\nChange-Id: I5f7fb5567365f51cae733909ff2ef09f63c7ccf9" }, { "commit": "07639d05f0f4ddd25d3ace0d256b98e1d5900130", "tree": "a021ed8a3d009da02a86bf81d1ce9f4dbb51feb2", "parents": [ "f1b239378265cd76e4426e1417b2ae6ce0eb764a" ], "author": { "name": "Nodir Turakulov", "email": "nodir@google.com", "time": "Sat Apr 21 16:08:37 2018" }, "committer": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Sat Apr 21 16:09:12 2018" }, "message": "[buildbucket-gerrit] use async in elements\n\nUse async/await ES feature in elements.\n\nAlso improve code reliability in a couple of places.\n\nChange-Id: I9fb7fd089324597c02365f0e9f34bf0e9b1a7118\nReviewed-on: https://chromium-review.googlesource.com/1022170\nReviewed-by: Quinten Yearsley \u003cqyearsley@chromium.org\u003e\n" }, { "commit": "f1b239378265cd76e4426e1417b2ae6ce0eb764a", "tree": "f954fff23730ebcc75aa471ce9f68c1527870015", "parents": [ "a8746235e8e24228a80f1d18af79659270741299" ], "author": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Fri Apr 20 22:24:56 2018" }, "committer": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Fri Apr 20 22:26:38 2018" }, "message": "buildbucket plugin: Update eslint config to handle async/await, fix warnings\n\nChange-Id: Ibc55cfa9d237bd6ace234fa369e7781a52db9bef\nReviewed-on: https://chromium-review.googlesource.com/1022084\nReviewed-by: Nodir Turakulov \u003cnodir@chromium.org\u003e\n" }, { "commit": "a8746235e8e24228a80f1d18af79659270741299", "tree": "5001f74c597face51c5dad28761bcf3f07a1fc0c", "parents": [ "f7a19e49ad7ae94d55a6770cafea82b15aa5c516" ], "author": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Fri Apr 20 16:26:35 2018" }, "committer": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Fri Apr 20 16:55:16 2018" }, "message": "Revert \"Refactor auth state storage in cr-buildbucket-client\"\n\nThis reverts commit b871fed9657852ac026b1efe740576f7323216a0.\n\nBug: 834772\nChange-Id: I02009c1e26d4207a31c1555dd72336add1176afa\nReviewed-on: https://chromium-review.googlesource.com/1019615\nReviewed-by: Nodir Turakulov \u003cnodir@chromium.org\u003e\n" }, { "commit": "f7a19e49ad7ae94d55a6770cafea82b15aa5c516", "tree": "8cd7bfb36d3f14ad63e05bafe61319f6bf1ca382", "parents": [ "c7335df4b6a77d1d20cbc0856a25e821098e7a6f" ], "author": { "name": "Nodir Turakulov", "email": "nodir@google.com", "time": "Thu Apr 19 22:36:15 2018" }, "committer": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Fri Apr 20 15:25:32 2018" }, "message": "[buildbucket-gerrit] support non-json bad responses\n\n_fetch assumes that all not-ok responses are necessarily JSON.\nThat proved to be incorrect. Try to parse body of a not-OK response\nas JSON, but if that fails, return a rejected promise with the textual\nbody.\n\nChange-Id: I58c0e535b223779ee83593a64ecbd1b918e2fd5c\nReviewed-on: https://chromium-review.googlesource.com/1020406\nReviewed-by: Quinten Yearsley \u003cqyearsley@chromium.org\u003e\n" }, { "commit": "c7335df4b6a77d1d20cbc0856a25e821098e7a6f", "tree": "8035b56a0b6eba3ade1589c8381f490ed2b78a63", "parents": [ "d4f45887c6e831c0dab6cd0b54af85ad454c10d1" ], "author": { "name": "Nodir Turakulov", "email": "nodir@google.com", "time": "Thu Apr 19 22:30:42 2018" }, "committer": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Fri Apr 20 15:24:33 2018" }, "message": "[buildbucket-gerrit] use async/await in tests\n\nInstead of calling done() or returning a promise, assume that gerrit-buildbucket\ndevelopers use modern browsers and use async/await in tests.\n\nChange-Id: I61654f6d985cb44e6b9680443db423e0980713a1\nReviewed-on: https://chromium-review.googlesource.com/1019549\nReviewed-by: Quinten Yearsley \u003cqyearsley@chromium.org\u003e\n" }, { "commit": "d4f45887c6e831c0dab6cd0b54af85ad454c10d1", "tree": "3c2629a346e55fa6a514d8122f420d37676acd6d", "parents": [ "682f3bc7cefa035d905daca3e9035a1ae92c3623" ], "author": { "name": "Nodir Turakulov", "email": "nodir@google.com", "time": "Thu Apr 19 15:25:33 2018" }, "committer": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Thu Apr 19 18:04:34 2018" }, "message": "[buildbucket-gerrit] refactor build scheduling\n\nRename trigger -\u003e schedule.\n\nChange scheduling API to deal with build requests and results,\nnot HTTP JSON request/response payloads.\n\nUse _fetch to schedule builds.\n\nDo not specify builder tag when scheduling a build.\nBuildbucket server adds it automatically.\n\nIn async tests, return promises instead of calling done().\n\nBug: 706095\nChange-Id: Iac77dacba565919766fca138a21ff94c0ce08410\nReviewed-on: https://chromium-review.googlesource.com/1017915\nReviewed-by: Quinten Yearsley \u003cqyearsley@chromium.org\u003e\n" }, { "commit": "682f3bc7cefa035d905daca3e9035a1ae92c3623", "tree": "4968f28afe466ed97056087ed2a80290e3e50c2d", "parents": [ "50ed25c6f5edfb5366b56dd9d2d2b038c94ed2c5" ], "author": { "name": "Nodir Turakulov", "email": "nodir@google.com", "time": "Thu Apr 19 01:10:08 2018" }, "committer": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Thu Apr 19 16:05:16 2018" }, "message": "[buildbucket-gerrit] fix _fetch\n\n_fetch helper ignores method and payload. Fix that.\n\nIn case of an error, assume the response is JSON and use it as a promise\nrejection reason.\n\nImprove tests. Use console.warn instead of console.error because wct\ntracks it and fails tests. Returns promises instead of accepting done().\n\nBug: 706095\nChange-Id: I994887ce191ebdeab427e9c2518f0ef8b2ad5be8\nReviewed-on: https://chromium-review.googlesource.com/1018496\nReviewed-by: Quinten Yearsley \u003cqyearsley@chromium.org\u003e\n" }, { "commit": "50ed25c6f5edfb5366b56dd9d2d2b038c94ed2c5", "tree": "12676222ba10dce593a6ccc68b6f7df3187a8ef5", "parents": [ "430662940fdced40e0b69fb1e567b491657e4862" ], "author": { "name": "Nodir Turakulov", "email": "nodir@google.com", "time": "Thu Apr 19 01:05:30 2018" }, "committer": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Thu Apr 19 16:05:11 2018" }, "message": "[buildbucket-gerrit] fix html import in picker\n\ncr-tryjob-picker_test.html, that doesn\u0027t load cr-buildbucket-view.html,\nfails because cr-buildbucket-client.html is not imported.\nAdd html-import of cr-buildbucket.client.html to cr-tryjob-picker.html\n\nBug: 706095\nChange-Id: If738f327450552c693866764a1e9d266b25a8d6f\nReviewed-on: https://chromium-review.googlesource.com/1018495\nReviewed-by: Quinten Yearsley \u003cqyearsley@chromium.org\u003e\n" }, { "commit": "430662940fdced40e0b69fb1e567b491657e4862", "tree": "9aab0c86b09b799928a09ea6d0173c9043405d5c", "parents": [ "6e624621a1436c79168e0ceb242cd69ef38770ca" ], "author": { "name": "Nodir Turakulov", "email": "nodir@google.com", "time": "Thu Apr 19 01:04:17 2018" }, "committer": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Thu Apr 19 16:05:05 2018" }, "message": "[buildbucket-gerrit] plumb plugin to client\n\ncr-tryjob-picker relies on cr-buildbucket-client that requires a Gerrit\nplugin object, but the picker doesn\u0027t initialize client\u0027s plugin.\nPlumb plugin to client when used inside picker.\n\nBug: 706095\nChange-Id: I2e1a7d2833bc3d1c657ccf2cba11dada011a7cbf\nReviewed-on: https://chromium-review.googlesource.com/1018492\nReviewed-by: Quinten Yearsley \u003cqyearsley@chromium.org\u003e\n" }, { "commit": "6e624621a1436c79168e0ceb242cd69ef38770ca", "tree": "467d5cf362eac36adda0e198b713c5b0c27d9465", "parents": [ "e56e171c98c43d99334ff0527ca36c06356189bc" ], "author": { "name": "Nodir Turakulov", "email": "nodir@google.com", "time": "Wed Apr 18 23:47:23 2018" }, "committer": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Wed Apr 18 23:48:42 2018" }, "message": "[buildbucket-gerrit] resort builds by id\n\nThe displayed builds may include builds from multiple patchsets\nif the later patchsets have only trivial changes;\nwe want builds from each builder to be shown in time order,\neven if they\u0027re from different patchsets.\n\nAn array formed by concatenating sorted arrays is not\nguaranteed to be sorted. Sort it again.\n\nBug: 706095\nChange-Id: Ibf4a95fbbf215c6d242f3109a47361a1cde09d4f\nReviewed-on: https://chromium-review.googlesource.com/1017233\nReviewed-by: Quinten Yearsley \u003cqyearsley@chromium.org\u003e\n" }, { "commit": "e56e171c98c43d99334ff0527ca36c06356189bc", "tree": "161c4b43e89d5466b1b12d944d29128c3666d9a0", "parents": [ "fa1587a221cff7d2dc0ee08b9435040688f497b9" ], "author": { "name": "Nodir Turakulov", "email": "nodir@google.com", "time": "Wed Apr 18 22:37:27 2018" }, "committer": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Wed Apr 18 23:40:48 2018" }, "message": "[buildbucket-gerrit] refactor build search code\n\nMake the code cleaner.\nThis is a preparation for sending other flavors of buildbucket API\nrequests.\n\nBug: 706095\nChange-Id: Ia5deb98a24cb08d74e632f2275482c8aaf0bb3b6\nReviewed-on: https://chromium-review.googlesource.com/1017018\nReviewed-by: Quinten Yearsley \u003cqyearsley@chromium.org\u003e\n" }, { "commit": "fa1587a221cff7d2dc0ee08b9435040688f497b9", "tree": "2716ded0b5e3adbab39412eb6cbfd5deb444f12d", "parents": [ "b871fed9657852ac026b1efe740576f7323216a0" ], "author": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Fri Apr 13 21:51:01 2018" }, "committer": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Mon Apr 16 22:52:11 2018" }, "message": "Buildbucket plugin: Add a timeout for oauth token refresh\n\nSimilar to change in tricium plugin: https://crrev.com/c/1003327\n\nBug: 816560\nChange-Id: I6a82350e71df5d43de8b5c8eef19346922b3f4f0\nReviewed-on: https://chromium-review.googlesource.com/1011344\nReviewed-by: Nodir Turakulov \u003cnodir@chromium.org\u003e\n" }, { "commit": "b871fed9657852ac026b1efe740576f7323216a0", "tree": "877c82e95cd5b0ee931e1019d45b8751804dd0a2", "parents": [ "7c3fe10386273b8d9200440d93798df28893cb39" ], "author": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Mon Apr 02 16:28:43 2018" }, "committer": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Mon Apr 02 17:02:29 2018" }, "message": "Refactor auth state storage in cr-buildbucket-client\n\nOriginally cr-buildbucket-client was set up so the same element\nmight be used for multiple different change pages, and auth state\nwas stored in an Object so that if there were multiple different\ncr-buildbucket-client elements, some redundant oauth configuration\nmight be avoided.\n\nIn practice, now, whenever a change page is loaded, a new request\nis made to get oauth config and get the oauth token.\n\nI believe that the _sharedAuthState Object is unnecessary,\nand removing it simplifies the code a little.\n\nChange-Id: Ic946ac73d7950b14631f5e5503537446a1261096\nReviewed-on: https://chromium-review.googlesource.com/987631\nReviewed-by: Aaron Gable \u003cagable@chromium.org\u003e\nReviewed-by: Nodir Turakulov \u003cnodir@chromium.org\u003e\n" }, { "commit": "7c3fe10386273b8d9200440d93798df28893cb39", "tree": "d08ae724953a13a4e1e42adf5874096c78c451d0", "parents": [ "f5940f2fcef2895081df2cabbf83e1f32b8fdd4e" ], "author": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Mon Apr 02 16:01:27 2018" }, "committer": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Mon Apr 02 16:24:20 2018" }, "message": "Fix plugin path in buildbucket run-with-prod-data.sh (2)\n\nI just submitted https://crrev.com/c/989850 with a typo,\nthis is a follow-up fix.\n\nChange-Id: I4b5e0ef507416222e7ace495c6526c79cca2df8a\nReviewed-on: https://chromium-review.googlesource.com/990075\nReviewed-by: Aaron Gable \u003cagable@chromium.org\u003e\n" }, { "commit": "f5940f2fcef2895081df2cabbf83e1f32b8fdd4e", "tree": "d3906ea2c6ed9bad650c53f49a08dc9362690606", "parents": [ "34ea720014c77395f113dcd097e23fc35a34251a" ], "author": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Mon Apr 02 15:41:52 2018" }, "committer": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Mon Apr 02 15:57:57 2018" }, "message": "Fix plugin path in buildbucket run-with-prod-data script\n\nChange-Id: I71452a940fc193172340c067215fcd9c6f923024\nReviewed-on: https://chromium-review.googlesource.com/989850\nReviewed-by: Aaron Gable \u003cagable@chromium.org\u003e\n" }, { "commit": "34ea720014c77395f113dcd097e23fc35a34251a", "tree": "7bc81fb9af1c2485164470a4ec848e86bfedaf1a", "parents": [ "64eec873cbf72d9421de3bfa9a1564eba7237150" ], "author": { "name": "Nodir Turakulov", "email": "nodir@google.com", "time": "Wed Mar 28 22:06:58 2018" }, "committer": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Wed Mar 28 22:14:44 2018" }, "message": "[buildbucket] remove TODO\n\nIn https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/984350/4..6/src/main/resources/static/cr-buildbucket-client.js#205\nnodir@ made incorrect comment. The code is not dead because it is then()\nfollowed by catch(), as opposed to catch() followed by then().\n\nR\u003dqyearsley@chromium.org\n\nChange-Id: I7a6faf15e304a6f69b716cdd46db8957d5b36bc4\nReviewed-on: https://chromium-review.googlesource.com/984739\nReviewed-by: Quinten Yearsley \u003cqyearsley@chromium.org\u003e\n" }, { "commit": "64eec873cbf72d9421de3bfa9a1564eba7237150", "tree": "d8107baf425c61b8780f86da841a9843b2046666", "parents": [ "be01d2edc97b5e5ece4ff7009a46eb485170ffd9" ], "author": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Wed Mar 28 22:01:10 2018" }, "committer": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Wed Mar 28 22:01:46 2018" }, "message": "Buildbucket plugin: Use dot notation for properties\n\nIn the _sharedAuthState member object of cr-buildbucket-client,\nit is defined as { OAUTH_CLIENT_ID: null, ... }, and I think the\nintent was to make an object with keys like \"oauth_client_id\", etc.\n\nIn order to make this object look like I expected it to look,\nthis CL changes it to just use the literals oauth_client_id,\nand use dot notation to access properties.\n\nThis is more conventional in JavaScript.\n\nhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Object_initializer\n\nChange-Id: I808c6aeaf8ad210a1186813a52976b6ffe2342a2\nReviewed-on: https://chromium-review.googlesource.com/984350\nReviewed-by: Nodir Turakulov \u003cnodir@chromium.org\u003e\n" }, { "commit": "be01d2edc97b5e5ece4ff7009a46eb485170ffd9", "tree": "a7b80cfa7198c12e4bfa5fb76a2528a9595d74f0", "parents": [ "c6d551e5a353161f64bf4ddc91f309600393a5df" ], "author": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Wed Mar 28 15:49:34 2018" }, "committer": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Wed Mar 28 17:53:05 2018" }, "message": "Buildbucket plugin: clarify timeout on error unit test\n\nThis CL changes that and modifies the test, and changes\nthe console.error to a console.warn so that the test\nbehaves as expected. This was necessary because in the\nunit test environment, console.error throws an exception.\n\nBug: 825272\nChange-Id: I9bf1bada1c0de4ad850faba654d10af50a814d8d\nReviewed-on: https://chromium-review.googlesource.com/978606\nReviewed-by: Nodir Turakulov \u003cnodir@chromium.org\u003e\n" }, { "commit": "c6d551e5a353161f64bf4ddc91f309600393a5df", "tree": "64f49ea0f1f050a611ed5f308a1112bea6997eac", "parents": [ "44bccd378adee727e4fcf09e9d06b12f863f1f40" ], "author": { "name": "Nodir Turakulov", "email": "nodir@google.com", "time": "Thu Feb 22 18:51:35 2018" }, "committer": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Thu Feb 22 18:58:33 2018" }, "message": "[gerrit-buildbucket] generalize baseURL\n\nRemove /_ah/api/buildbucket/v1 from base URL so that the same baseURL\ncan be used for /_ah/api/swarmbucket/v1\n\nBug: 706095\nChange-Id: I658dd97c00ee144dbb191ad6753bf2449d0aa1d1\nReviewed-on: https://chromium-review.googlesource.com/932011\nReviewed-by: Aaron Gable \u003cagable@chromium.org\u003e\n" }, { "commit": "44bccd378adee727e4fcf09e9d06b12f863f1f40", "tree": "4b4c998aadc58de38efb786d7f376c8ae2e29cca", "parents": [ "30693e7e421ffac4eafdb7fd7b42ea033c7ce309" ], "author": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Tue Feb 20 19:12:59 2018" }, "committer": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Tue Feb 20 20:37:05 2018" }, "message": "Buildbucket plugin: update run-with-prod-data.sh\n\nRelated CL in Tricium plugin repo is https://crrev.com/c/927010.\n\nChange-Id: Ibf86c4f2be15eca88350a701a3d27812da5e8da8\nReviewed-on: https://chromium-review.googlesource.com/926788\nReviewed-by: Aaron Gable \u003cagable@chromium.org\u003e\n" }, { "commit": "30693e7e421ffac4eafdb7fd7b42ea033c7ce309", "tree": "cd8cc73dbf159642aca4e8bfc2fd5847e3973ea7", "parents": [ "d575eaf88b5ce1344e2817cb3e14292a49347925" ], "author": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Mon Feb 05 22:22:41 2018" }, "committer": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Tue Feb 06 16:17:54 2018" }, "message": "Change entry point for Buildbucket plugin to buildbucket.html\n\nAdvantage: We can load the cr-buildbucket-view element\nvia HTML import instead of Polymer.Base.importHref.\nRelated CL for Tricium: https://crrev.com/c/895053\n\nBug: 796638\nChange-Id: Ie2bcb1c0d66ef950c17fab3fa77be3791fd4a704\nReviewed-on: https://chromium-review.googlesource.com/895904\nReviewed-by: Aaron Gable \u003cagable@chromium.org\u003e\nReviewed-by: Nodir Turakulov \u003cnodir@chromium.org\u003e\n" }, { "commit": "d575eaf88b5ce1344e2817cb3e14292a49347925", "tree": "2e7325b85297d33d4089e536e00528fed5ac6bc1", "parents": [ "0cfdf46742f92427cf9e4c6067614e0354a23a74" ], "author": { "name": "Nodir Turakulov", "email": "nodir@google.com", "time": "Mon Feb 05 23:32:19 2018" }, "committer": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Mon Feb 05 23:34:32 2018" }, "message": "[buildbucket] clear update timer\n\nBug 1: Buildbucket plugin makes O(N) requests every 5 sec, where\nN is the number of CLs visited in the same Chrome tab. This happens\nbecause window timeout is never explicitly cleared.\n\nBug 2: if a CL is open and then user navigates back to the dashboard,\nthe plugin continues to poll buildbucket.\n\nTogether, they caused excessive QPS on Buildbucket. According to Buildbucket\nlogs, majority of search requests from Gerrit came with referral\n\"https://chromium-review.googlesource.com/dashboard/self\".\n\nThis CL fixes both CLs by clearing update timeout on detach and before\ncreating a new timeout. Also it reverts 9edbc39289f531744a5e418a35967328b7a98c79\n\nBug: 803356, 809166\nChange-Id: I72c00c5b8f7871fb9f65bf0df0a853b6115f39b9\nReviewed-on: https://chromium-review.googlesource.com/902815\nReviewed-by: Aaron Gable \u003cagable@chromium.org\u003e\n" }, { "commit": "0cfdf46742f92427cf9e4c6067614e0354a23a74", "tree": "56287ed928dbdb5b32ccd4524cf51b6fde16a126", "parents": [ "9edbc39289f531744a5e418a35967328b7a98c79" ], "author": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Mon Feb 05 21:28:53 2018" }, "committer": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Mon Feb 05 22:31:06 2018" }, "message": "Add a helper script to run with Gerrit testsite.\n\nThis CL copies a script from the Tricium repo which may be helpful\nin local development for testing with a local Gerrit test site.\n\nMost of the time I find it still more helpful to use PolyGerrit\nwith production data, but this can be useful for some cases,\ne.g. verifying that the Java part still builds and works.\n\nChange-Id: Iaf76d8fd2c3c2fdebe8e0abac2907356add246e8\nReviewed-on: https://chromium-review.googlesource.com/902764\nReviewed-by: Nodir Turakulov \u003cnodir@chromium.org\u003e\n" }, { "commit": "9edbc39289f531744a5e418a35967328b7a98c79", "tree": "0c2c9a8f615dfcc4b386b514973566591daa33ca", "parents": [ "0f63153fbfe0035f99e54c270f8fc109f4585b32" ], "author": { "name": "Nodir Turakulov", "email": "nodir@google.com", "time": "Thu Jan 18 21:51:53 2018" }, "committer": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Thu Feb 01 18:23:07 2018" }, "message": "Double default polling interval.\n\nThis should decrease number of GerritPlugin-\u003eBuildbucket queries by 2.\nGiven that 63% of buidbucket requests come from browser\nhttps://bigquery.cloud.google.com/savedquery/174799409470:613972970ce640a4bcc738664094e621\nand Gerrit Buildbucket plugin is the only known buildbucket js client, this CL\nshould reduce Buildbucket QPS by ~31%.\n\nBug: 803356\nChange-Id: I5b776e6ef89bc4b06c99246da47651dc74a50bc3\nReviewed-on: https://chromium-review.googlesource.com/875122\nReviewed-by: Aaron Gable \u003cagable@chromium.org\u003e\n" }, { "commit": "0f63153fbfe0035f99e54c270f8fc109f4585b32", "tree": "dca25dcde3d6f167aef44abe6d965986e291a7fa", "parents": [ "44385671f2f19668c36c531c30215dfebfad893c" ], "author": { "name": "Aaron Gable", "email": "agable@chromium.org", "time": "Wed Jan 31 17:42:26 2018" }, "committer": { "name": "Aaron Gable", "email": "agable@chromium.org", "time": "Wed Jan 31 23:36:54 2018" }, "message": "Better and forward-compatible autofocus\n\nEven though iron-input-behavior (which gr-overlay imports) tries\nto focus elements with the \u0027autofocus\u0027 attribute, it only does so\nfor element in the light dom. Because the filter input element is\npart of cr-tryjob-picker\u0027s shadow dom, it doesn\u0027t get focused\nby iron-input-behavior.\n\nThe solution is to have iron-input-behavior focus the only element\nit can (the top-level cr-tryjob-picker itself), and then have that\nfocus trigger an on-focus handler, which then sets focus to the\nplace we want it.\n\nThis cannot be done in _handleChooseTryJobsOpen because doing so\nresults in a race between iron-input-behavior and us trying to set\nfocus.\n\nBug: 806971\nChange-Id: Id95e30b1517ddb7d6145e9a6498f8a4b68a54d15\nReviewed-on: https://chromium-review.googlesource.com/895845\nReviewed-by: Sean McCullough \u003cseanmccullough@chromium.org\u003e\n" }, { "commit": "44385671f2f19668c36c531c30215dfebfad893c", "tree": "a172b5c4eabbcdf4272fcba0c43d6700262f5f60", "parents": [ "8b6bbfc8104e5015735e36c577b072bdfbb7326d" ], "author": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Wed Jan 31 17:56:40 2018" }, "committer": { "name": "Quinten Yearsley", "email": "qyearsley@chromium.org", "time": "Wed Jan 31 18:03:45 2018" }, "message": "Clean up temp dir in run-with-prod-data.sh\n\nContext: This is a suggested change in https://crrev.comc/c/889420\nfrom the corresponding script in tricium.\n\nChange-Id: I185dc7095ee11b930dd0601773af50136ac4774c\nReviewed-on: https://chromium-review.googlesource.com/895047\nReviewed-by: Nodir Turakulov \u003cnodir@chromium.org\u003e\n" }, { "commit": "8b6bbfc8104e5015735e36c577b072bdfbb7326d", "tree": "dccc2e71caa4e56bc30940785bb14cd4e426cc6e", "parents": [ "283b806d9b601269e9d34acfe92758486b19136a" ], "author": { "name": "Aaron Gable", "email": "agable@chromium.org", "time": "Wed Jan 31 00:41:41 2018" }, "committer": { "name": "Aaron Gable", "email": "agable@chromium.org", "time": "Wed Jan 31 00:44:20 2018" }, "message": "Autofocus filter input when opening overlay\n\nThis is only a partial solution: although the input element\nwill be focused the first time the overlay is opened, it\ndoesn\u0027t become focused on future openings. This is despite\nthe fact that iron-overlay-behavior (which the parent element,\ngr-overlay, imports) explicitly has support for focusing\nany [autofocus] elements. It\u0027s not clear why that isn\u0027t\nworking as expected.\n\nR\u003dseanmccullough\n\nBug: 806971\nChange-Id: I572b4a491a8de7cd46b0a583417c6d43c4a2373a\nReviewed-on: https://chromium-review.googlesource.com/894845\nReviewed-by: Sean McCullough \u003cseanmccullough@chromium.org\u003e\n" }, { "commit": "283b806d9b601269e9d34acfe92758486b19136a", "tree": "fcca1a8e323d79b3cad51a3de8911fb8e9681bc7", "parents": [ "133a885974bce8300fe0a426d0d782758f5e4c6d" ], "author": { "name": "Aaron Gable", "email": "agable@chromium.org", "time": "Tue Jan 30 20:11:35 2018" }, "committer": { "name": "Aaron Gable", "email": "agable@chromium.org", "time": "Tue Jan 30 23:07:30 2018" }, "message": "Formatting tweaks to match the Google HTML style guide\n\nR\u003dqyearsley\n\nChange-Id: Ie94e5c86e465c2f5ce25a5edb8a3c31edb6bd674\nReviewed-on: https://chromium-review.googlesource.com/893708\nReviewed-by: Quinten Yearsley \u003cqyearsley@chromium.org\u003e\n" }, { "commit": "133a885974bce8300fe0a426d0d782758f5e4c6d", "tree": "b429bc355c2d5d6a641115be3fa1c9b4d602ae68", "parents": [ "b25dac99f28b5c62b863114b8db9309ee6294942" ], "author": { "name": "Aaron Gable", "email": "agable@chromium.org", "time": "Mon Jan 22 23:16:00 2018" }, "committer": { "name": "Aaron Gable", "email": "agable@chromium.org", "time": "Mon Jan 22 23:23:18 2018" }, "message": "Refresh builds whenever current patchset changes\n\nWithout this change, a user can use the patchset selector to change\nwhich patchset they\u0027re viewing, and the \"Viewing changes from...\"\ntext will immediately update, but the displayed builds themselves\nwon\u0027t update until the next time the update timer fires.\n\nThis change causes all changes to the list of valid patchsets\n(which happens when the user uses the patchset selector dropdown)\nto trigger a network fetch and recomputation.\n\nThis is necessary now, when it wasn\u0027t before, because previously\nusing the patchset selector caused a full page refresh, and the\nplugin was loaded from scratch. Making the full network request\nis necessary under the current design because we don\u0027t store all\nthe builds which are returned, just those which are relevant to\nthe current patchsets.\n\nBug: 800620\nChange-Id: I335a4c555170e3099fb2b4d24cef0273faafcb16\nReviewed-on: https://chromium-review.googlesource.com/878926\nReviewed-by: Nodir Turakulov \u003cnodir@chromium.org\u003e\n" } ], "next": "b25dac99f28b5c62b863114b8db9309ee6294942" }