Cache text-artifact fetches and add loading indicator

Currently, repeatedly opening and closing a result row will lead to
multiple fetches. This change lets replaceTextArtifacts cache successful
fetches with a new LRUCacheObject also added in this change.

Also, some fetches can take up to 1 second during which a user will see
a blank result row. To indicate that the plugin is loading text
artifacts, this change adds a "Loading..." text before being replaced
by the CheckResult's HTML message.

Bug: 1174869
Change-Id: I507dde60873fc0d330796e0b976bc58f777429b3
Reviewed-on: https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/2841748
Reviewed-by: Weiwei Lin <weiweilin@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
5 files changed
tree: efa0d8348a3c70dfdebd6bb17394c3625f9c2df7
  1. .eslintrc.json
  2. .gitignore
  3. BUILD
  4. LICENSE
  5. OWNERS
  6. README.md
  7. bower.json
  8. codereview.settings
  9. package-lock.json
  10. package.json
  11. run-with-prod-data.sh
  12. run-with-testsite.sh
  13. src/
  14. test/
  15. wct.conf.json
README.md

Buildbucket Plugin for Gerrit

Usage

This plugin is configured via the buildbucket.config file present in the repo‘s refs/meta/config ref, as well as the same file in all repositories in the repo’s inheritance chain (up to and including All-Projects).

An example buildbucket.config is below:

[host]
  git = "chromium.googlesource.com"
  gerrit = "chromium-review.googlesource.com"

[bucket "luci.chromium.try"]
[bucket "luci.chrome.try"]

In the vast majority of cases, the host.git and host.gerrit values are global to the entire host, so that stanza is specified in the All-Projects repo. Buckets and builders, on the other hand, are almost always very repository-specific, and so are only specified in “leaf” repositories which are not in any other repo's inheritance chain.

All changes to buildbucket.config files are instantly reflected. There is no caching period or need to restart the server.

If your project doesn't want the “retry failed” button to show, you can disable it:

[option]
  hide-retry-button = true

Development

To use with the local testsite

Use the script run-with-testsite.sh; this rebuilds the plugin with bazel, copies it over and restarts the local testsite. Example invocation:

GERRIT_DIR=~/gerrit GERRIT_TESTSITE_DIR=~/testsite ./run-with-testsite.sh

To use with the polygerrit-ui server against live data

Use the script run-with-prod-data.sh; this creates a temporary directory with the plugin source in the expected layout and then invokes polygerrit-ui/run-server.sh. Example invocation:

GERRIT_DIR=~/gerrit ./run-with-prod-data.sh

Testing

npm run wct-test

Note: Testing is disabled for Safari due to this issue.