Cache token promise instead of token result

This doesn't fix the issue of JWTs needing to be enabled, but it helps
with returning the first checks result quicker. This means a faster
load time.

Bug: 1149429
Change-Id: I9e3bcfa1c66e2fede0a8893488e21c5d598fadfb
Reviewed-on: https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/3752048
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
2 files changed
tree: 1b4c45fd60f360fe35707557b9243f56fd709231
  1. src/
  2. web/
  3. .eslintrc.json
  4. .gitignore
  5. BUILD
  6. codereview.settings
  7. LICENSE
  8. OWNERS
  9. README.md
  10. run-with-prod-data.sh
  11. run-with-testsite.sh
README.md

Buildbucket Plugin for Gerrit

Usage

This plugin is configured via the buildbucket.config file present in the repo‘s refs/meta/config ref, as well as the same file in all repositories in the repo’s inheritance chain (up to and including All-Projects).

An example buildbucket.config is below:

[host]
  git = "chromium.googlesource.com"
  gerrit = "chromium-review.googlesource.com"

[bucket "luci.chromium.try"]
[bucket "luci.chrome.try"]

In the vast majority of cases, the host.git and host.gerrit values are global to the entire host, so that stanza is specified in the All-Projects repo. Buckets and builders, on the other hand, are almost always very repository-specific, and so are only specified in “leaf” repositories which are not in any other repo's inheritance chain.

All changes to buildbucket.config files are instantly reflected. There is no caching period or need to restart the server.

If your project doesn't want the “retry failed” button to show, you can disable it:

[option]
  hide-retry-button = true

If your project uses Quick Run/RTS and wants to surface the rocket ship icon 🚀 for builds using Quick Run, you can show it by setting rts_was_used = true in the output properties (example recipe).

Setup

This plugin must be placed inside the Gerrit plugins directory:

git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit/plugins
git clone https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket

Web Plugin Development

Run the commands below in web/.

For running unit tests execute:

make test

For checking or fixing eslint formatter problems run:

make lint_test
make lint_fix

For testing the plugin with Gerrit FE Dev Helper the following command builds the JavaScript bundle and copies it to the plugins/buildbucket folder:

make build

and let the Dev Helper redirect from .+/plugins/buildbucket/static/buildbucket.js to http://localhost:8081/plugins_/plugins/buildbucket.js.

Note: Testing is disabled for Safari due to this issue.