Google Git
Sign in
chromium / infra / gerrit-plugins / buildbucket / b14150ebf1183eab41e5cd4d450d217dac95c183
commitb14150ebf1183eab41e5cd4d450d217dac95c183[log] [tgz]
authorGavin Mak <gavinmak@google.com>Tue Apr 06 17:21:48 2021
committerGavin Mak <gavinmak@google.com>Tue Apr 06 17:21:48 2021
tree483f781073fa77782e0c8aea0fb9aba0bdc1b6da
parentcaef873cf02301f868514a9f8fd32bd0668b067a [diff]
Use innerHTML in installChecksResult and support <text-artifact/>

This change uses the sanitizer to safely set the value of innerHTML in
CheckResult rows. To support <text-artifact/>, convertBuildToRun adds
artifact-href attributes to <text-artifact/> elements from the fetched
artifact list. Upon expanding a CheckResult row, the text artifacts are
fetched and replace the <text-artifact/> element.

Bug: 1191200, 1174869
Change-Id: Ie92ab0b822f5c5a753be769b23c73e197b51bf87
Reviewed-on: https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/2803466
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
4 files changed
tree: 483f781073fa77782e0c8aea0fb9aba0bdc1b6da
  1. src/
  2. test/
  3. .eslintrc.json
  4. .gitignore
  5. bower.json
  6. BUILD
  7. codereview.settings
  8. LICENSE
  9. OWNERS
  10. package-lock.json
  11. package.json
  12. README.md
  13. run-with-prod-data.sh
  14. run-with-testsite.sh
  15. wct.conf.json
README.md

Buildbucket Plugin for Gerrit

Usage

This plugin is configured via the buildbucket.config file present in the repo‘s refs/meta/config ref, as well as the same file in all repositories in the repo’s inheritance chain (up to and including All-Projects).

An example buildbucket.config is below:

[host]
  git = "chromium.googlesource.com"
  gerrit = "chromium-review.googlesource.com"

[bucket "luci.chromium.try"]
[bucket "luci.chrome.try"]

In the vast majority of cases, the host.git and host.gerrit values are global to the entire host, so that stanza is specified in the All-Projects repo. Buckets and builders, on the other hand, are almost always very repository-specific, and so are only specified in “leaf” repositories which are not in any other repo's inheritance chain.

All changes to buildbucket.config files are instantly reflected. There is no caching period or need to restart the server.

If your project doesn't want the “retry failed” button to show, you can disable it:

[option]
  hide-retry-button = true

Development

To use with the local testsite

Use the script run-with-testsite.sh; this rebuilds the plugin with bazel, copies it over and restarts the local testsite. Example invocation:

GERRIT_DIR=~/gerrit GERRIT_TESTSITE_DIR=~/testsite ./run-with-testsite.sh

To use with the polygerrit-ui server against live data

Use the script run-with-prod-data.sh; this creates a temporary directory with the plugin source in the expected layout and then invokes polygerrit-ui/run-server.sh. Example invocation:

GERRIT_DIR=~/gerrit ./run-with-prod-data.sh

Testing

npm run wct-test

Note: Testing is disabled for Safari due to this issue.