Fix chooseTryjobsCallback and remove args from filterExperimentsCallback

"Choosing tryjobs" button currently schedules runs with encoded project
URLs. For example, a depot_tools tryjob should have the project field
chromium/tools/depot_tools but this becomes chromimum%2Ftools%2Fdepot_tools
and causes the run to fail.

Instead, only the project URL should be encoded for fetching the plugin
config and not for scheduling builds.

This change also removes unneeded arguments to filterExperimentsCallback.

Bug: 1203391, 1174869
Change-Id: I0d39aefdff095bb3990f068a5a4033ad02d756bb
Reviewed-on: https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/2855011
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
1 file changed
tree: bb50b6af238d500e80f0770cdeea9bdc7331d4a6
  1. src/
  2. test/
  3. .eslintrc.json
  4. .gitignore
  5. bower.json
  6. BUILD
  7. codereview.settings
  8. LICENSE
  9. OWNERS
  10. package-lock.json
  11. package.json
  12. README.md
  13. run-with-prod-data.sh
  14. run-with-testsite.sh
  15. wct.conf.json
README.md

Buildbucket Plugin for Gerrit

Usage

This plugin is configured via the buildbucket.config file present in the repo‘s refs/meta/config ref, as well as the same file in all repositories in the repo’s inheritance chain (up to and including All-Projects).

An example buildbucket.config is below:

[host]
  git = "chromium.googlesource.com"
  gerrit = "chromium-review.googlesource.com"

[bucket "luci.chromium.try"]
[bucket "luci.chrome.try"]

In the vast majority of cases, the host.git and host.gerrit values are global to the entire host, so that stanza is specified in the All-Projects repo. Buckets and builders, on the other hand, are almost always very repository-specific, and so are only specified in “leaf” repositories which are not in any other repo's inheritance chain.

All changes to buildbucket.config files are instantly reflected. There is no caching period or need to restart the server.

If your project doesn't want the “retry failed” button to show, you can disable it:

[option]
  hide-retry-button = true

Development

To use with the local testsite

Use the script run-with-testsite.sh; this rebuilds the plugin with bazel, copies it over and restarts the local testsite. Example invocation:

GERRIT_DIR=~/gerrit GERRIT_TESTSITE_DIR=~/testsite ./run-with-testsite.sh

To use with the polygerrit-ui server against live data

Use the script run-with-prod-data.sh; this creates a temporary directory with the plugin source in the expected layout and then invokes polygerrit-ui/run-server.sh. Example invocation:

GERRIT_DIR=~/gerrit ./run-with-prod-data.sh

Testing

npm run wct-test

Note: Testing is disabled for Safari due to this issue.