commit 0883e573802ef0b656ca2b972c28fd1cf8b99c42
author Anthony Polito <apolito@google.com> Tue Nov 12 23:21:08 2019
committer Anthony Polito <apolito@google.com> Tue Nov 12 23:21:08 2019
tree fb0ec40235f410d3a0bfba31395bcceb4c3a6c46
parent d8b24628f1ae20485319024bc591c02f9aed3137

Don't depend on banner z levels, hide close button when it should be hidden.

Bug: 1021262
Change-Id: If219e0166481cc815bcfb6a64616c999d28af259

src/main/resources/static/chromium-behavior.html

diff --git a/src/main/resources/static/chromium-behavior.html b/src/main/resources/static/chromium-behavior.html
index cf8830c..d20da6a 100644
--- a/src/main/resources/static/chromium-behavior.html
+++ b/src/main/resources/static/chromium-behavior.html
@@ -778,7 +778,8 @@
           'right: 5px;' +
           'top: 1px;' +
           'color: #777;' +
-          'cursor: pointer;',
+          'cursor: pointer;' +
+          'visibility: hidden;',
         styleMessage: 'margin: 0px;',
     };
 
@@ -837,6 +838,7 @@
           // Add a cookie for announcements in the banner so they don't reappear.
           shownAnnouncements.forEach(ann => setClosedBannerCookie(ann.id));
           shownAnnouncements = [];
+          closeBtn.style.visibility = 'hidden';
         }
         closeBtn.addEventListener('click', closeBanner);
         // Set up calls to chopsdash to fetch live announcements
@@ -849,9 +851,12 @@
               (!announcementCookieExists(ann.id))));
             const messages = shownAnnouncements.map(ann => ann.messageContent);
             message.textContent = messages.join('\r\n');
+            closeBtn.style.visibility = messages.length() ?
+                'visible' : 'hidden';
           }).catch((e) => {
             console.log(e);
             message.textContent = 'Unable to get outage announcements from ChOpsDash.';
+            closeBtn.style.visibility = 'visible';
           });
         }