commit 2860215719e8f10204b3de9e6961453425f83630
author Ravi Mistry <rmistry@google.com> Thu Nov 08 16:25:38 2018
committer Ravi Mistry <rmistry@chromium.org> Thu Nov 08 16:26:44 2018
tree f1fd06c6d3899da06349e6d9b5e7a58e0d6df0cd
parent 8accf52ee8b4ddec45acb05800c745acdbd0ff1c

Add support for projects with any CR/CQ label values to chromium-behavior plugin

Bug: 883001
Change-Id: I4fbcd44a944ebb27169a914a88d133417c148fcc

src/main/resources/static/chromium-behavior.html

diff --git a/src/main/resources/static/chromium-behavior.html b/src/main/resources/static/chromium-behavior.html
index 3c2bd84..f7fae88 100644
--- a/src/main/resources/static/chromium-behavior.html
+++ b/src/main/resources/static/chromium-behavior.html
@@ -5,9 +5,7 @@
     const AUTOSUBMIT_LABEL = 'Auto-Submit';
     const AS_LABEL_MAX_VALUE = 1;
     const REVIEW_LABEL = 'Code-Review';
-    const REVIEW_LABEL_MAX_VALUE = 1;
     const CQ_LABEL = 'Commit-Queue';
-    const CQ_LABEL_MAX_VALUE = 2;
     const STATUS_SUBMITTED = 'MERGED';
 
     // Constants used by the AutoSubmit behaviors below.
@@ -535,9 +533,10 @@
 
       // Show neither the Revert nor Reland actions to non-committer drive-bys.
       PLUGIN.restApi().get('/accounts/self/detail').then(currentUser => {
+        const reviewLabelMaxValue = getLabelMaxValue(change, REVIEW_LABEL);
         if (currentUser.email !== change.owner.email &&
             !isLabelVotePermitted(change, REVIEW_LABEL,
-                                  '+' + REVIEW_LABEL_MAX_VALUE)) {
+                                  '+' + reviewLabelMaxValue)) {
           changeActions.setActionHidden(changeActions.ActionType.CHANGE,
                                         changeActions.ChangeActions.REVERT,
                                         true);
@@ -703,10 +702,10 @@
     const approveAndSubmitRevert = function(change) {
       let labels = {};
       // Auto-approve reverts.
-      labels[REVIEW_LABEL] = REVIEW_LABEL_MAX_VALUE;
+      labels[REVIEW_LABEL] = getLabelMaxValue(change, REVIEW_LABEL);
       // Immediately send to CQ only if _CQ_CHECKBOX_ID is checked.
       if (document.getElementById(_CQ_CHECKBOX_ID).checked) {
-        labels[CQ_LABEL] = CQ_LABEL_MAX_VALUE;
+        labels[CQ_LABEL] = getLabelMaxValue(change, CQ_LABEL);
       }
       return labels;
     };