chromium-behavior: Don't submit revert automatically to the CQ.
This changes the behavior of the "Revert" button so that it is consistent
with "Reland", and so that it doesn't lead to developers accidentally
reverting changes when they are not ready for that.
This is done by never auto-checking the "Send to CQ" checkbox.
Making this change will also reduce the need for addressing
https://crbug.com/856249, although clarification could still be helpful.
Bug: 1074163
Change-Id: Ifbe9232b174f630ed806072e4f9100a6acd33e76
diff --git a/src/main/resources/static/chromium-behavior.html b/src/main/resources/static/chromium-behavior.html
index 12cf075..2344872 100644
--- a/src/main/resources/static/chromium-behavior.html
+++ b/src/main/resources/static/chromium-behavior.html
@@ -156,7 +156,6 @@
const cqCheck = document.createElement('input');
cqCheck.type = 'checkbox';
- cqCheck.checked = true;
cqCheck.style = CQ_INPUT_STYLES.styleCheck;
cqSpan.appendChild(cqCheck);
</script>
@@ -652,7 +651,6 @@
const interceptRevertMessage = function(change, revertMsg, originalMsg) {
if (!change.labels[CQ_LABEL]) {
cqSpan.style = CQ_INPUT_STYLES.styleHidden;
- cqCheck.checked = false;
return revertMsg;
}
// Add email-style quoting ('> ') in front of the original commit text.
@@ -709,7 +707,6 @@
alert('Note: The CL will not be automatically sent to the CQ and ' +
'the CQ checks will not be skipped because this CL landed ' +
'more than 1 day ago.');
- cqCheck.checked = false;
cqSpan.style = CQ_INPUT_STYLES.styleHidden;
newDescription += '# Not skipping CQ checks because original CL ' +
'landed > 1 day ago.\n\n';
