Postpone check if buttons are installed

There's a race condition when BUTTON_INSTALLED variable is set and
checked. It's possible that label vote listener is called before
BUTTON_INSTALLED is properly set yielding to AS+1 -> CQ+2 not WAI.

R=aravindvasudev@google.com

Change-Id: Ia0b071627fd5509b7e61b2ea222ed81bc27bd2a6
1 file changed
tree: 0904be8b3c8580341e006fe2ee691cb67dad6043
  1. web/
  2. .eslintrc.json
  3. .gitignore
  4. codereview.settings
  5. LICENSE
  6. OWNERS
  7. polymer.json
  8. README.md
  9. run-with-prod-data.sh
  10. WATCHLISTS
README.md

Chrome/Chromium behavior theme for Gerrit

Setup

This plugin must be placed inside the Gerrit plugins directory:

git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit/plugins
git clone https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior

Web Plugin Development

For running TypeScript unit tests execute:

bazel test --test_output=all //plugins/chromium-behavior/web:karma_test

For checking or fixing eslint formatter problems run:

bazel test //plugins/chromium-behavior/web:lint_test
bazel run //plugins/chromium-behavior/web:lint_bin -- \
  --fix "$(pwd)/plugins/chromium-behavior/web"

For testing the plugin with Gerrit FE Dev Helper build the JavaScript bundle and copy it to the plugins/chromium-behavior folder:

bazel build //plugins/chromium-behavior/web:chromium-behavior
cp -f bazel-bin/plugins/chromium-behavior/web/chromium-behavior.js plugins/

Start polygerit-ui server:

./polygerrit-ui/run-server.sh --plugins="plugins"

and let the Dev Helper redirect from .+/plugins/chromium-behavior/static/chromium-behavior.js to http://localhost:8081/plugins/chromium-behavior.js.