commit c5f513fd5dca18719dd78ad5e370c70fb1b49ec7
author Josip Sokcevic <sokcevic@google.com> Fri Mar 18 17:27:25 2022
committer Josip Sokcevic <sokcevic@google.com> Fri Mar 18 17:27:25 2022
tree 0904be8b3c8580341e006fe2ee691cb67dad6043
parent d7c1eaf4643308affe2a696cee34491d40e084af

Postpone check if buttons are installed

There's a race condition when BUTTON_INSTALLED variable is set and
checked. It's possible that label vote listener is called before
BUTTON_INSTALLED is properly set yielding to AS+1 -> CQ+2 not WAI.

R=aravindvasudev@google.com

Change-Id: Ia0b071627fd5509b7e61b2ea222ed81bc27bd2a6

web/autosubmit.ts

diff --git a/web/autosubmit.ts b/web/autosubmit.ts
index ac863e5..1fb1b6c 100644
--- a/web/autosubmit.ts
+++ b/web/autosubmit.ts
@@ -221,15 +221,15 @@
  *       Inform user that CQ+2 was automatically set
  */
 export function installLabelValuesCallbackAutosubmit(plugin: PluginApi) {
-  if (!BUTTONS_INSTALLED) {
-    return;
-  }
   const replyApi = plugin.changeReply();
   replyApi.addLabelValuesChangedCallback(
     async (labelDetail: LabelsChangedDetail, change?: ChangeInfo) => {
       if (!change) {
         return;
       }
+      if (!BUTTONS_INSTALLED) {
+        return;
+      }
       const reviewApproved =
         replyApi.getLabelValue(REVIEW_LABEL) === `+${REVIEW_LABEL_MAX_VALUE}`;
       const autoSubmitApproved = isAutoSubmitApproved(change, replyApi);