| commit | d7c1eaf4643308affe2a696cee34491d40e084af | [log] [tgz] |
|---|---|---|
| author | Josip Sokcevic <sokcevic@google.com> | Tue Mar 15 22:29:08 2022 |
| committer | Josip Sokcevic <sokcevic@google.com> | Tue Mar 15 22:29:08 2022 |
| tree | cc172865c57bc71998a0657ef9107e84f716987a | |
| parent | f2152f7a83a121aa248ca566ef33c62196055fe4 [diff] |
Check label permissions on votes change Some conditions aren't checked on label change callback. Instead of copying them from the install function, use global state to indicate whether to display or not. R=gavinmak@google.com Fixed: 1306251 Change-Id: I890cdeb1f0af1ce6239592df841a24f535fe9b83
This plugin must be placed inside the Gerrit plugins directory:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit/plugins git clone https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior
For running TypeScript unit tests execute:
bazel test --test_output=all //plugins/chromium-behavior/web:karma_test
For checking or fixing eslint formatter problems run:
bazel test //plugins/chromium-behavior/web:lint_test bazel run //plugins/chromium-behavior/web:lint_bin -- \ --fix "$(pwd)/plugins/chromium-behavior/web"
For testing the plugin with Gerrit FE Dev Helper build the JavaScript bundle and copy it to the plugins/chromium-behavior folder:
bazel build //plugins/chromium-behavior/web:chromium-behavior cp -f bazel-bin/plugins/chromium-behavior/web/chromium-behavior.js plugins/
Start polygerit-ui server:
./polygerrit-ui/run-server.sh --plugins="plugins"
and let the Dev Helper redirect from .+/plugins/chromium-behavior/static/chromium-behavior.js to http://localhost:8081/plugins/chromium-behavior.js.