Google Git
Sign in
chromium / infra / gerrit-plugins / chromium-behavior / f16cadac6e6c3d586bbe979f3ab32da6ff098461
commitf16cadac6e6c3d586bbe979f3ab32da6ff098461[log] [tgz]
authorScott Lee <ddoman@chromium.org>Mon Jan 29 18:45:35 2024
committerScott Lee <ddoman@chromium.org>Mon Jan 29 18:45:35 2024
tree4f657adf6bd0deb514b0dc85ec460cf79d6f0b29
parentd10987d4290f25e4cd3d39570a1ba92153ab7290 [diff]
[chromium-behaviour] lint fixes

All the changes are made by `make lint_fix` except for one change,
which I left a comment and should be safe.

Although not all the logc/functions with the lint fixes have
unit tests, I assume this existing tests are good enough.

Change-Id: I63fdb6d54fb113b46c71e8ee6b36afff0cd3f358
6 files changed
tree: 4f657adf6bd0deb514b0dc85ec460cf79d6f0b29
  1. web/
  2. .eslintrc.json
  3. .gitignore
  4. codereview.settings
  5. LICENSE
  6. OWNERS
  7. polymer.json
  8. README.md
  9. run-with-prod-data.sh
  10. WATCHLISTS
README.md

Chrome/Chromium behavior theme for Gerrit

Setup

This plugin must be placed inside the Gerrit plugins directory:

git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit/plugins
git clone https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior

Web Plugin Development

Run the commands below in web/.

For running TypeScript unit tests execute:

make test

For checking or fixing eslint formatter problems run:

make lint_test
make lint_fix

For testing the plugin with Gerrit FE Dev Helper the command below builds the JavaScript bundle and copies it to the plugins/chromium-behavior folder:

make build

Start polygerit-ui server:

./polygerrit-ui/run-server.sh --plugins="plugins"

and let the Dev Helper redirect from .+/plugins/chromium-behavior/static/chromium-behavior.js to http://localhost:8081/plugins/chromium-behavior.js.