Google Git
Sign in
chromium / infra / gerrit-plugins / chromium-binary-size
Clone this repo:

Branches

  1. d29ca0c Set maximum decimal places to 1 in human readable delta by Mohamed Heikal · 12 months ago main
  2. a282979 Put size summary in the Chromium Binary Size chip by Mohamed Heikal · 1 year, 1 month ago
  3. 07a150e Use check result to pass around data by Gavin Mak · 2 years ago
  4. 4b74e3d Fix ts 5.0 compile errors by Ben Rohlfs · 2 years, 4 months ago
  5. c07f2dd Cleanup OAuth flow by Aravind Vasudevan · 2 years, 10 months ago

Chromium Binary Size Plugin for Gerrit

How it works

The plugin queries the android-binary-size trybot for the current patchset on Gerrit, and gets the binary_size_plugin property. This property contains the metadata about the binary size metrics affected by the patchset in question. It then shows a table with the metric deltas + links to SuperSize output under the Checks tab.

Usage

This plugin is configured via the chromium-binary-size.config file present in the repo‘s refs/meta/config ref, as well as the same file in all repositories in the repo’s inheritance chain (up to and including All-Projects).

An example chromium-binary-size.config is below (this enables the plugin on the chromium/src repo using the android-binary-size trybot:

[host]
  gerrit = "chromium-review.googlesource.com"

[repo "chromium/src"]
  builder = "android-binary-size"
  bucket = "try"
  project = "chromium"

All changes to chromium-binary-size.config files are instantly reflected. There is no caching period or need to restart the server.

Development

Setup

This plugin must be placed inside the Gerrit plugins directory:

git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit/plugins
git clone https://chromium.googlesource.com/infra/gerrit-plugins/chromium-binary-size

Web Plugin Development

Run the commands below in web/.

For running Java unit tests execute:

make test_java

For running TypeScript unit tests execute:

make test

For checking or fixing eslint formatter problems run:

make lint_test
make lint_fix

For testing the plugin with Gerrit FE Dev Helper the command below builds the JavaScript bundle and copies it to the plugins/chromium-binary-size folder:

make build

and let the Dev Helper redirect from .+/plugins/chromium-binary-size/static/chromium-binary-size.js to http://localhost:8081/plugins_/plugins/chromium-binary-size.js.