| commit | a9a0d6cc04f712504758a6604953e60bdee09664 | [log] [tgz] |
|---|---|---|
| author | Joanna Wang <jojwang@chromium.org> | Fri Feb 24 04:30:08 2023 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Feb 24 04:30:08 2023 |
| tree | c98a71e78966d4593d6edddcf691fa0a207ed714 | |
| parent | 483b80ee2b04fe74d76a8e2872eee3b0665010a3 [diff] |
Add info on how inheritance and how to disabled for child repos. Change-Id: I9ac84eb0a6e8d2a51dd9683930e3ebc21d6513ea Reviewed-on: https://chromium-review.googlesource.com/c/infra/gerrit-plugins/chumpdetector/+/4290387 Auto-Submit: Joanna Wang <jojwang@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
This plugin will allow developers to see the current status on their CLs. Status will be pulled from a configurable location. The Chromium project has many status sites such as:
The plugin will show users the status and will warn them in certain situations if they attempt to undertake actions that are contrary to the tree status.
The plugin does not provide enforcement - that is provided by other systems.
Before this plugin will work you'll need to configure it. You can do that by adding a new file to refs/meta/config for a Gerrit project. The configuration file should be called chumpdetector.config and should be of the form:
[project "some-interesting-project"]
loginURL = https://login.appspot.com/?next=chromium-status
viewURL = https://chromium-status.appspot.com/
statusURL = https://chromium-status.appspot.com/current?format=json
withCredentials = false
enforceCommitQueue = false
disabledBranchPattern = ^(refs/meta/config|.*)$
The project name doesn‘t matter, it can be anything you’d like
If withCredentials is true and a request for status fails, the system assumes that a login is required and has not occurred. In that case the status message will change to “Login required. Click here to login.” The text will be a link that points to the value of loginURL. If loginURL is not set then the message will just be RequestError: Login required. with no link.
This should be the URL to your status app. This is used to provide a link that users can click on to take them to a new page that shows the full status.
This should be the URL to get a JSON blob of the current status. Usually this will be related to the viewURL value. This is the URL that will be queried via XHR periodically while the user is on the page to update the tree status.
This is simply passed through to the underlying JavaScript XMLHttpRequest object as the withCredentials parameter. You can read about it at https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/withCredentials
When true, this will show a modal warning to users if they try to submit the CL directly and warn them to use the CQ. This is Chromium concept, unless you have a Chromium-like CQ system. Just leave as false if you don't understand what any of those things mean.
Anyone defining this property is strongly recommended to include
refs/meta/configsince we never enable the CQ on this branch.
CLs on branches that match this pattern will have the plugin disabled. This means they won‘t see tree status and tree status won’t effect the CL in any way.
The branch name comes from the Gerrit CL ChangeInfo. The refs/heads/ prefix is omitted, but otherwise is the full name. Common examples are main (in the case of refs/heads/main) and refs/meta/config.
The pattern syntax uses JavaScript Regular expressions with no flags. This means the match is case-sensitive, and you should use ^ and $ anchors to avoid accidental partial matches. For example, the pattern main will match any branch name that has the substring main in it, not only the main branch itself.
There is no need to quote the string. If quotes are used, they are automatically stripped (outermost only). For example, "^main$" is turned into ^main$.
This setting causes the plugin to request a URL via an an image that is dynamically added to the page before making any other fetch requests. This is useful in situations where the request to the status URL will fail without certain cookies being set for the status request domain. By using an image tag the browser will correctly follow any redirects that a login process may require in order to establish the session cookies.
Most installs will not need this configuration and can ignore it. For certain sites this may allow them to get security cookies before attempting status requests which will fail without the cookies.
Repos with no chumpdetector.config will inherit it from the inheritFrom repo in project.config. To disable the plugin for a repo, without breaking the inheritance, create a chumpdetector.config for the repo with:
[project "some-project-name"] disabled = true
Run the commands below in web/.
For running TypeScript unit tests execute:
make test
For checking or fixing eslint formatter problems run:
make lint_test make lint_fix
For testing the plugin with Gerrit FE Dev Helper the command below builds the JavaScript bundle and copies it to the plugins/chumpdetector folder:
make build
Start polygerit-ui server:
./polygerrit-ui/run-server.sh --plugins="plugins"
and let the Dev Helper redirect from .+/plugins/chumpdetector/static/chumpdetector.js to http://localhost:8081/plugins/chumpdetector.js.