commit | d3e2efa82950387577d40d23baf26eb81c0e6c9f | [log] [tgz] |
---|---|---|
author | Wyatt Allen <wyatta@google.com> | Tue Jun 26 20:18:52 2018 |
committer | Wyatt Allen <wyatta@google.com> | Tue Jun 26 20:18:52 2018 |
tree | ce4640b34088971413bce256797529baf8ff4c37 | |
parent | 76a9f16a0a65561b7b3f28bf90d57d64c841846b [diff] |
Show submit warning in confirm dialog Rather than using the browser's native window.confirm method to inform users about dangerous submits, set the message inside the confirm submit dialog's plugin endpoint. This allows the message to be more informative and prevents extraneous multiple confirmations. https://bugs.chromium.org/p/gerrit/issues/detail?id=8794 Change-Id: I3adef72761ccbf23e1da8f1aadf8a3d13b20363a Reviewed-on: https://chromium-review.googlesource.com/1111237 Reviewed-by: Aaron Gable <agable@chromium.org>
ln -s /path/to/chumpdetector-plugin plugins/chumpdetector NO_BUCKD=1 buck build plugins/chumpdetector && \ cp buck-out/gen/plugins/chumpdetector/chumpdetector.jar ../gerrit_testsite/plugins/ && \ ../gerrit_testsite/bin/gerrit.sh restart
mkdir -p polygerrit-ui/app/plugins/chumpdetector ln -s /path/to/chumpdetector-plugin/src/main/resources/static polygerrit-ui/app/plugins/chumpdetector/static ./polygerrit-ui/run-server.sh -host chromium-review.googlesource.com
You may also need to edit chumpdetectorURL
to point directly at chromium-review.googlesource.com
instead of being relative.