Google Git
Sign in
chromium / infra / gerrit-plugins / git-numberer / 17a27225a18f93495976c4979daaa9390ee4d914
commit17a27225a18f93495976c4979daaa9390ee4d914[log] [tgz]
authorJosip Sokcevic <sokcevic@google.com>Tue Jan 11 22:06:58 2022
committerJosip Sokcevic <sokcevic@google.com>Tue Jan 11 22:06:58 2022
tree3238060a9c5b1609c593246438407b3ff58baac4
parent36aa4df30a9f1f057ec69fda2cf8a3a00f44163f [diff]
Revert "Some equal git branches are more equal than others"

This reverts commit 4d540a5b1cb52e84f58967bc41004f59ba389953.

Change-Id: Idc9be14dddfe6e338d37161f3ddad7ace7c2289b
Reviewed-on: https://chromium-review.googlesource.com/c/infra/gerrit-plugins/git-numberer/+/3361155
Reviewed-by: Anthony Polito <apolito@google.com>
4 files changed
tree: 3238060a9c5b1609c593246438407b3ff58baac4
  1. src/
  2. .gitignore
  3. BUILD
  4. codereview.settings
  5. LICENSE
  6. OWNERS
  7. README.md
README.md

Git Numberer Gerrit Plugin

This plugin ensures commit footers in a repository comply with rules of Git number footers for Chromium and is part of the Git Numberer for Chromium system.

Summary

For every new commit C that is about to be pushed with git push or landed using Gerrit API/UI (called merged in Gerrit), this plugin ensures:

  1. commit C having exactly at most one parent, namely commit P.
  2. commit P contains footer Cr-Commit-Position: refs/foo/bar@{#X}, where X is positive integer.
  3. commit C contains footer Cr-Commit-Position: refs/foo/bar@{#Y} such that Y = X+1.

There is more to it in the doc Git number footers for Chromium.

Plugin structure

This plugin consists of verification and generation parts, each working independently of each other, but share common libraries. While each part can be enabled on specific refs independently of another, it's recommended that verifier is enabled on all refs on which generation is enabled.

Verification

Safety comes first. This plugin installs a verifier that ensures that all new commits on enabled refs comply with the numbering scheme. The new commits may be created as a result of landing (merging) a Gerrit changelist, or as a result of a git push operation.

NOTE This is a Gerrit plugin and thus it only works for operations done through Gerrit. Thus, this plugin won‘t protect from bad commits being pushed by someone with direct access to Git repository filesystem on Gerrit’s server. Google's deployment of Gerrit internally calls such access _direct push. Such access could be useful to administrators when pushing humongous histories as in during Chromium + Blink merge, but then administrators are responsible for verification.

See also:

  • git cl and its fork in Commit Queue which generate footers for Rietveld issues.

Development

Get Ready, only once.

Follow this general Gerrit guide first to get basic set up correctly.

Code/Build/Test

Checkout (or symlink) this repo into plugins/git-numberer directory inside primary Gerrit checkout.

bazel build git-numberer
bazel test git_numberer_tests

References