| commit | c4f7da01652a897d29277a6ab82ca9c1eea0f4d8 | [log] [tgz] |
|---|---|---|
| author | Tao Zhou <taoalpha@google.com> | Wed Dec 04 17:00:11 2019 |
| committer | Tao Zhou <taoalpha@google.com> | Wed Dec 04 17:00:11 2019 |
| tree | e2c98b9aee85e2ea106d97f69d4fd129695a79a4 | |
| parent | b81133e9952f0f2c84527c4e973ece38a7d0e91f [diff] |
Use shared styles provided by gerrit for a more consistent UX Dark theme: https://imgur.com/m9fPF06 Light theme: https://imgur.com/tKcUHsB Change-Id: Ie4ecb7bd3d86c17bd1ccf407b34bb4e61e85d14b Reviewed-on: https://chromium-review.googlesource.com/c/infra/gerrit-plugins/tricium/+/1950463 Reviewed-by: Andy Perelson <ajp@chromium.org>
Tricium is a code analysis service for Chromium. The purpose of this plugin is to integrate with the Gerrit UI, e.g. by displaying progress of analyzers.
To check out the Tricium plugin code:
git clone https://chromium.googlesource.com/infra/gerrit-plugins/tricium
The unit tests of the plugin are web-component-tester unit tests. Dependencies are specified in bower.json and can be installed by running bower install in this directory. This requires bower to be installed.
To run the tests, run wct from this directory. See wct --help for more options.
With a local static web server, such as the one provided by Polymer CLI, you can also view and tweak UI interactively.
To install the Polymer tool-set globally, run npm install -g polymer-cli.
You can create a local instance of Gerrit and use this plugin in that instance.
If needed, install bazel, and then build from the Gerrit repo root with bazel build plugins/tricium.
The Gerrit repo includes a script for trying the PolyGerrit UI with a local server local plugins but with production data. See run-with-prod-data.sh.
To set up to run PolyGerrit with a local copy of the plugin, first get the Gerrit repo:
git clone --recursive https://gerrit.googlesource.com/gerrit
Then move or link the Tricium repo so it's inside the gerrit/plugins/ directory, e.g. mv tricium gerrit/plugins/.
Known issue: with a locally run PolyGerrit, you can‘t log in, which means robot comment actions (e.g. the “not useful” button) aren’t visible by default.
To bypass this issue, follow the instructions below:
http://localhost:8081/plugins/tricium/src/main/resources/static/tricium.html to the injectHtmlCode field. Note that the port might not be 8081 depending on how you started the local server. Make sure you use the correct port number.https://cdn.googlesource.com/polygerrit_assets/282.0/2194a55.html, but may have a different version and hash. You can search for the correct link in the “Network” section of Chrome's developer console. b. In the configuration menu for the Gerrit Dev Helper extension, add a rule to block all requests to the polygerrit assets link you found before.https://chromium-review.googlesource.com/plugins/tricium/static/tricium.html to http://localhost:8081/plugins/tricium/src/main/resources/static/tricium.html.It's also possible to test with a local instance of Gerrit.
To do this you must set up a Gerrit test site. To build the tricium plugin in Gerrit, it is assumed that the tricium directory is iniside the gerrit plugins directory.
Then, the local site could be started with Tricium by running run-with-testsite.sh.
This plugin is configured via the tricium.config file present in the repo's refs/meta/config ref. This file uses git config format. Example:
[host] tricium = tricium-prod.appspot.com