Google Git
Sign in
chromium / infra / infra.git / 0381f14599f44368b4039c36924eca2c585dd5c9
commit0381f14599f44368b4039c36924eca2c585dd5c9[log] [tgz]
authorFumitoshi Ukai <ukai@google.com>Tue Apr 23 08:14:00 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 23 08:14:00 2024
tree891046c551b111a7914799f6c4e5f0e5ad7188d1
parent1909dcbccb38732806329ff931fdc08fc7de5eb4 [diff]
siso: retry cas read blob

still seeing failure to read blobs
https://ci.chromium.org/ui/p/chromium/builders/build/win-build-perf-siso/268/overview

[95653/102857] CXX obj/chrome/browser/web_applications/web_applications_browser_tests/preinstalled_web_app_manager_browsertest.obj
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /c ../../chrome/browser/web_applicatio...(too long)
remote-exec 15df775b3ca8ccca26dd3fd3fabb3ac43e4773f55d9ba250c64580139ea07908/373 failed no-fallback: failed to read blobs 8cc4dc7ef35023269baee6c52f5778e0de95c438ff906d6a5679689fb7d97958/310919 for stdout: rpc error: code = Unavailable desc = error reading from server: read tcp 10.0.34.232:53678->142.250.125.95:443: wsarecv: An existing connection was forcibly closed by the remote host.
error: 1 steps failed

We expect grpc reties, but there are some case it fails?
Explicitly retry in caller side.

Bug: b/328332495
Change-Id: I31f23dc4046c98738da7f47326621a793ec726d3
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/5475090
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Cr-Commit-Position: refs/heads/main@{#64726}
1 file changed
tree: 891046c551b111a7914799f6c4e5f0e5ad7188d1
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. crdx/
  8. doc/
  9. docker/
  10. go/
  11. infra/
  12. node/
  13. packages/
  14. python_pb2/
  15. rbe/
  16. recipes/
  17. test/
  18. utils/
  19. luci
  20. .gitallowed
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .style.yapf
  25. .vpython
  26. .vpython3
  27. .yapfignore
  28. codereview.settings
  29. CONTRIBUTING.md
  30. DEPS
  31. LICENSE
  32. navbar.md
  33. OWNERS
  34. PRESUBMIT.py
  35. README.md
  36. run.py
  37. test.py
  38. WATCHLISTS
  39. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.