Google Git
Sign in
chromium/infra/infra.git/1898ac7b5de912885f1d0e72e95a843d1a2ce061
commit
1898ac7b5de912885f1d0e72e95a843d1a2ce061
[log] [tgz]
author
Jae Hoon Kim <kimjae@google.com>
Fri Jan 16 23:45:40 2026
committer
Jae Hoon Kim <kimjae@google.com>
Fri Jan 16 23:45:40 2026
tree
ff33f16ef93a3f247ff8f3c5c34d10c54f8ed4d7
parent
26276473ada21c22d92d318e583400b25b089225 [diff]
Add option to skip boot property check in RetrySetupAdb

This change updates `RetrySetupAdb` to accept a variadic boolean
parameter to optionally skip the Android boot property check
(`sys.boot_completed`).

When provisioning GKI (Generic Kernel Image) instances, verifying basic
ADB reachability is sufficient and preferable to waiting for full boot
properties, which may differ in that environment.

- Update `RetrySetupAdb` signature to accept `opts ...bool`.
- If `opts[0]` is true, return immediately after ADB setup without
  running `IsBootCompleted`.
- Update `checkADB` wrapper to propagate these options.
- Enable this skip logic in `FullOSImageState` specifically for GKI
  instances.

Changes: 
Bug: 468016611
Test: go build <services>
Change-Id: I9cc96bba9243e181426f71ff332dd6dfd669d1a6
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/7489703
Auto-Submit: Jae Hoon Kim <kimjae@chromium.org>
Reviewed-by: Garry Wang <xianuowang@chromium.org>
Reviewed-by: Chris DeLaGarza <cdelagarza@google.com>
Commit-Queue: Chris DeLaGarza <cdelagarza@google.com>
Cr-Commit-Position: refs/heads/main@{#78459}
3 files changed
tree: ff33f16ef93a3f247ff8f3c5c34d10c54f8ed4d7
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. crdx/
  8. doc/
  9. docker/
  10. go/
  11. infra/
  12. node/
  13. packages/
  14. python_pb2/
  15. rbe/
  16. recipes/
  17. test/
  18. utils/
  19. luci
  20. .gitallowed
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .style.yapf
  25. .vpython
  26. .vpython3
  27. .yapfignore
  28. codereview.settings
  29. CONTRIBUTING.md
  30. DEPS
  31. LICENSE
  32. navbar.md
  33. OWNERS
  34. PRESUBMIT.py
  35. README.md
  36. run.py
  37. SECURITY_OWNERS
  38. test.py
  39. WATCHLISTS
  40. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.