commit | 2b06dd929fada77ed1eb78fa0c89cbe0d3bcb609 | [log] [tgz] |
---|---|---|
author | Dave Tu <dtu@google.com> | Fri Jun 14 21:17:24 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jun 14 21:17:24 2019 |
tree | 9198663d1baf68f5d7bbd5ddbf90c0bdea7478fe | |
parent | 39fe1941a666c741de0dc97905f8aa6bc61ba09c [diff] |
[monorail] Add issue detail SPA ts_mon metrics. We want to measure two metrics: * Time from Navigation Start to Comment List, for when the user is navigating into the SPA from outside. ("from outside app") * Time from Click to Comment List, for when the user is navigating within the SPA. ("within app") These metrics do not include the non-JS work: style, layout, paint, composite, which may be ~10-100 ms based on the number of comments. For marking the "Click", it's hard to keep track of all the links that navigate to other issues, so instead I've used the start of the issue detail page load. This is ~1-10 ms after the click. Marking when the comment list is rendered is surprisingly difficult. I've used MrIssueDetails.updated() because there is only one on the issue detail page. The number and order of updates vary based on the order of network responses, so I've added some filters to pinpoint only the cases we care about. These filters may or may not prove to be brittle in the future. lit-element updates as also asynchronous, so I recursively collect all the child nodes and wait for all of them to finish updating. Bug: monorail:5565 Change-Id: Id6a77833974563f9cd6b65034a92af590a64746e Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/1650135 Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org> Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Dave Tu <dtu@chromium.org> Cr-Commit-Position: refs/heads/master@{#23694}
Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, integrate your tests with test.py:
Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have init.py files in each directory of your module so Python recognizes it as a package.