[mojo] Remove root from search path and update comment I thought about changing mojom.gni, but it's kind of brittle, because the generator doesn't actually need the gen import path, so it's possible that someone might remove this and silently break indexing. Putting it in mojom_indexer in g3 also doesn't really make sense, because it should only be concerned with processing the input it's given. Having it inside package_index is not great, but it's the least bad IMO. Fixed: 277438505 Change-Id: I353ba243d7962e19355ed82725b377e13c59b011 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/7477277 Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Auto-Submit: Fred Shih <ffred@chromium.org> Cr-Commit-Position: refs/heads/main@{#78425}
Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path modifications.git push origin <updated hash>:deployedgit push commandIf you've added a new module, run your tests with test.py:
*_test.py files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.