Google Git
Sign in
chromium / infra / infra.git / 7984d892c04e2530cb9bbc155b2e0dcfb259b919
commit7984d892c04e2530cb9bbc155b2e0dcfb259b919[log] [tgz]
authorChris DeLaGarza <cdelagarza@google.com>Fri Jun 21 16:10:28 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jun 21 16:10:28 2024
treeafa6d907855cb2f8759dd9857346bb58820efabb
parentd477e67efe0d3a56c851077b0a70d4e4d9d2d6dd [diff]
infra/infra: Add indirect replacements to go.mod

As pointed out in the comments of https://chromium-review.googlesource.com/c/infra/infra/+/5630816?tab=comments `go list -m -json all` is failing to run and causing some Golang IDEs to fail indexing the project.

I assumed that indirect replace directives would've been picked up by the command, but as it turns out the replace values need to be present for the `go list -m -json all` command.

BUG=None
TEST=`go list -m -json all`

Change-Id: I9f22c5902b46885c419f39b0c2ba074fc2f579cf
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/5647225
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Chris DeLaGarza <cdelagarza@google.com>
Cr-Commit-Position: refs/heads/main@{#66345}
1 file changed
tree: afa6d907855cb2f8759dd9857346bb58820efabb
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. crdx/
  8. doc/
  9. docker/
  10. go/
  11. infra/
  12. node/
  13. packages/
  14. python_pb2/
  15. rbe/
  16. recipes/
  17. test/
  18. utils/
  19. luci
  20. .gitallowed
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .style.yapf
  25. .vpython
  26. .vpython3
  27. .yapfignore
  28. codereview.settings
  29. CONTRIBUTING.md
  30. DEPS
  31. LICENSE
  32. navbar.md
  33. OWNERS
  34. PRESUBMIT.py
  35. README.md
  36. run.py
  37. test.py
  38. WATCHLISTS
  39. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.