Google Git
Sign in
chromium / infra / infra.git / e83330288c3547931b63dd1d4a1164aa44e9f0ba
commite83330288c3547931b63dd1d4a1164aa44e9f0ba[log] [tgz]
authorFumitoshi Ukai <ukai@google.com>Wed Apr 24 06:57:40 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 24 06:57:40 2024
tree0d13e717bb9e97d720f5d80c1f2ae6f6fa23cc81
parent3133d1557a01148ce9fcf3bb41423d581e0ef6cd [diff]
siso: don't remove generated file not in out dir.

Due to gn restriction, ios build uses a trick of noop step
to expose files in build graph. These files are placed out of
workspace, but available via symlink in out dir created by `gn gen`
time.

noop step has outputs, so siso record cmdhash to the output files,
but siso hashfs resolves intermediate symlink dir, so cmdhash
is recorded in actual real pathname.

For cleandead, it checks generated files (which have cmdhash in
hashfs state), but such generated files are not matched with files
in build graph, so considered as dead file.

In the first place, we should not remove files not in out dir
by cleandead.

Bug: b/336667052
Change-Id: I989bf70d373f3a29c904cf098666da899366734d
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/5481370
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#64754}
7 files changed
tree: 0d13e717bb9e97d720f5d80c1f2ae6f6fa23cc81
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. crdx/
  8. doc/
  9. docker/
  10. go/
  11. infra/
  12. node/
  13. packages/
  14. python_pb2/
  15. rbe/
  16. recipes/
  17. test/
  18. utils/
  19. luci
  20. .gitallowed
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .style.yapf
  25. .vpython
  26. .vpython3
  27. .yapfignore
  28. codereview.settings
  29. CONTRIBUTING.md
  30. DEPS
  31. LICENSE
  32. navbar.md
  33. OWNERS
  34. PRESUBMIT.py
  35. README.md
  36. run.py
  37. test.py
  38. WATCHLISTS
  39. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.