Google Git
Sign in
chromium/infra/infra.git/bd56f6f32080849298e66a80cc4ca12a9f2c67e8
commit
bd56f6f32080849298e66a80cc4ca12a9f2c67e8
[log] [tgz]
author
Yuke Liao <liaoyuke@chromium.org>
Mon Jan 19 06:58:14 2026
committer
LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>
Mon Jan 19 06:58:14 2026
tree
200a513137a82081057e5584bd527303f0652199
parent
22799a3b32d56dede430ad1a2e3b528d43b76ef2 [diff]
Skip race tests on Mac

The race tests failed on Mac with the following logs:

FAIL go.chromium.org/build/siso [build failed] xcode-select: note: no
developer tools were found at '/Applications/Xcode.app', requesting
install. Choose an option in the dialog to download the command line
developer tools.

It requires additional setup in the build environment. Since race
conditions are generally platform-independent, running race tests on
Linux (where CGO is readily available) should be sufficient to catch
generic race conditions.

This CL modifies the recipe to skip `go test -race` on Mac and adds a
test case to verify that race tests are skipped on Mac.

Bug: b/451910833
Change-Id: I23e0656f47e83a45389dd100f83bd87d2df6ebb0
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/7489039
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@google.com>
Cr-Commit-Position: refs/heads/main@{#78477}
1 file changed
tree: 200a513137a82081057e5584bd527303f0652199
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. crdx/
  8. doc/
  9. docker/
  10. go/
  11. infra/
  12. node/
  13. packages/
  14. python_pb2/
  15. rbe/
  16. recipes/
  17. test/
  18. utils/
  19. luci
  20. .gitallowed
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .style.yapf
  25. .vpython
  26. .vpython3
  27. .yapfignore
  28. codereview.settings
  29. CONTRIBUTING.md
  30. DEPS
  31. LICENSE
  32. navbar.md
  33. OWNERS
  34. PRESUBMIT.py
  35. README.md
  36. run.py
  37. SECURITY_OWNERS
  38. test.py
  39. WATCHLISTS
  40. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.