Google Git
Sign in
chromium/infra/infra.git/c5a609c0ac997686acbfa6b8606069dd237b2058
commit
c5a609c0ac997686acbfa6b8606069dd237b2058
[log]
author
Chris DeLaGarza <cdelagarza@google.com>
Fri Jun 21 16:54:17 2024
committer
LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>
Fri Jun 21 16:54:17 2024
tree
a82d836b51d23ff4d2745ae090c1a711d292fd08
parent
7984d892c04e2530cb9bbc155b2e0dcfb259b919 [diff]
ctpv2: Grab filters from firestore

Update filter container info building to grab from the firestore.

Updated logic goes as follows:
1. Get metadata container info.
2. Get container info from firestore.
3. Get filter container info from input.
4. Build default and non-default containers using the combined info from 1-3.

BUG=b:323374380
TEST=led

Change-Id: Idc10016af29de2ba3a1d41afa6e1d3b5239c91e8
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/5646720
Reviewed-by: Derek Beckett <dbeckett@chromium.org>
Reviewed-by: Azizur Rahman <azrahman@google.com>
Commit-Queue: Chris DeLaGarza <cdelagarza@google.com>
Cr-Commit-Position: refs/heads/main@{#66346}
10 files changed
tree: a82d836b51d23ff4d2745ae090c1a711d292fd08
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. crdx/
  8. doc/
  9. docker/
  10. go/
  11. infra/
  12. node/
  13. packages/
  14. python_pb2/
  15. rbe/
  16. recipes/
  17. test/
  18. utils/
  19. luci
  20. .gitallowed
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .style.yapf
  25. .vpython
  26. .vpython3
  27. .yapfignore
  28. codereview.settings
  29. CONTRIBUTING.md
  30. DEPS
  31. LICENSE
  32. navbar.md
  33. OWNERS
  34. PRESUBMIT.py
  35. README.md
  36. run.py
  37. test.py
  38. WATCHLISTS
  39. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.