Google GitGoogle Git
Sign in
chromium/infra/infra.git/dafdf6c5985201ef2e2dfe8928fb827c04512d47
commit
dafdf6c5985201ef2e2dfe8928fb827c04512d47
[log]
author
Vadim Shtayura <vadimsh@chromium.org>
Thu Mar 14 00:01:09 2019
committer
Commit Bot <commit-bot@chromium.org>
Thu Mar 14 00:01:09 2019
tree
a10110e5b8f57bc7a70795fedadba6ecd39bc51b
parent
2cbcc68d36679f05d73c2be2f032a68637800ce5 [diff]
[cr-buildbucket] Start recognizing X-Luci-Project headers.

Still fallback (with logging) to checking e.g. 'luci-scheduler@...' is in the
ACL, so this CL doesn't break everything.

Another caveat is that PermittedActions RPC does not recognize X-Luci-Project
and everything will break horribly if callers (Milo?) will try to pass
X-Luci-Project. But this should be fine, since PermittedActions is supposed to
be used ONLY when checking end-user's roles and it relies on delegation tokens
instead of X-Luci-Project (these two mechanism are incompatible and impossible
to use together).

R=nodir@chromium.org
BUG=938083

Change-Id: Ie77c0056d3906c519be4c4545092ae5730f836ff
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/1519648
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#21412}
3 files changed
tree: a10110e5b8f57bc7a70795fedadba6ecd39bc51b
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. cipd/
  7. crdx/
  8. data/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. recipes/
  17. test/
  18. utils/
  19. .gitattributes
  20. .gitignore
  21. codereview.settings
  22. CONTRIBUTING.md
  23. DEPS
  24. LICENSE
  25. navbar.md
  26. OWNERS
  27. PRESUBMIT.py
  28. README.md
  29. run.py
  30. test.py
  31. WATCHLISTS
  32. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, integrate your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. More your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have init.py files in each directory of your module so Python recognizes it as a package.