Google Git
Sign in
chromium / infra / infra.git / e100df521a25554305a79d6a6dee40028c786650
commite100df521a25554305a79d6a6dee40028c786650[log] [tgz]
authorWarren Whitman <warrenpw@google.com>Mon Jan 19 06:40:02 2026
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jan 19 06:40:02 2026
treefcffe7a78e2e0686d30440eeb2c5912fb1e6c362
parent2a9f68f3996f3a1b243ab8d6d34a0bed202d0ed1 [diff]
Correct Logs for Selected Deletion Function

Update log messages for deletion method selected for asset removal
during nlyte sync to properly state controller instead of registration.

TEST=make test
Bug: b:475260738

Change-Id: I28cf55d411ee8a3e3a06734a31eab4f766b15ed8
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/7487701
Auto-Submit: Warren Whitman <warrenpw@google.com>
Commit-Queue: Gowri Denduluri <gowriden@google.com>
Reviewed-by: Gowri Denduluri <gowriden@google.com>
Cr-Commit-Position: refs/heads/main@{#78474}
1 file changed
tree: fcffe7a78e2e0686d30440eeb2c5912fb1e6c362
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. crdx/
  8. doc/
  9. docker/
  10. go/
  11. infra/
  12. node/
  13. packages/
  14. python_pb2/
  15. rbe/
  16. recipes/
  17. test/
  18. utils/
  19. luci
  20. .gitallowed
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .style.yapf
  25. .vpython
  26. .vpython3
  27. .yapfignore
  28. codereview.settings
  29. CONTRIBUTING.md
  30. DEPS
  31. LICENSE
  32. navbar.md
  33. OWNERS
  34. PRESUBMIT.py
  35. README.md
  36. run.py
  37. SECURITY_OWNERS
  38. test.py
  39. WATCHLISTS
  40. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.