Google Git
Sign in
chromium / infra / infra.git / ed14ba96f418e4bc58465b890a5a65dae03326f7
commited14ba96f418e4bc58465b890a5a65dae03326f7[log] [tgz]
authorKeith Haddow <haddowk@chromium.org>Thu Jun 20 05:19:42 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jun 20 05:19:42 2024
tree2e5bd40565c30f2823ee2986b630d78803ff3616
parentb71808a3e1daefd910f5edc773d2b3f8ace35e82 [diff]
Revert "Servo repair, Dolos mux direction and set correct power on defaults."

This reverts commit 32fbb933c6d4731b72762304a32c45d580d96be6.

Reason for revert: Seems to fail SSH into Labstation and can leave the Labstation in a bad state NO_SSH

Original change's description:
> Servo repair, Dolos mux direction and set correct power on defaults.
>
> To access the Dolos console we need the lower type A port to be
> visible to the labstation, for now we are deciding based on if
> Dolos is deployed for a device later we need to have settings
> in UFS.
>
> BUG=b:345235915
> TEST=mallet run
>
> Change-Id: I1e19719754f1fef4fa59be5ec40acf2d1c955af2
> Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/5637488
> Commit-Queue: Keith Haddow <haddowk@chromium.org>
> Auto-Submit: Keith Haddow <haddowk@chromium.org>
> Reviewed-by: Otabek Kasimov <otabek@google.com>
> Commit-Queue: Otabek Kasimov <otabek@google.com>
> Cr-Commit-Position: refs/heads/main@{#66299}

Bug: b:345235915
Change-Id: Idddc103d9924f9c078682bfa361c3ff3fdd1cc26
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/5643750
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Garry Wang <xianuowang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#66312}
14 files changed
tree: 2e5bd40565c30f2823ee2986b630d78803ff3616
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. crdx/
  8. doc/
  9. docker/
  10. go/
  11. infra/
  12. node/
  13. packages/
  14. python_pb2/
  15. rbe/
  16. recipes/
  17. test/
  18. utils/
  19. luci
  20. .gitallowed
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .style.yapf
  25. .vpython
  26. .vpython3
  27. .yapfignore
  28. codereview.settings
  29. CONTRIBUTING.md
  30. DEPS
  31. LICENSE
  32. navbar.md
  33. OWNERS
  34. PRESUBMIT.py
  35. README.md
  36. run.py
  37. test.py
  38. WATCHLISTS
  39. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.