commit | 7550559d683b056d209a0eab6619f11c0316c69e | [log] [tgz] |
---|---|---|
author | Gregory NISBET <gregorynisbet@google.com> | Fri Apr 19 22:03:36 2024 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Apr 19 22:03:36 2024 |
tree | 5eeb965f18a6a59c265fe26c8630530e7e7c4e55 | |
parent | 1d56c27ac66e14523fd220066d56fbcbe2c4b288 [diff] |
[fleetcost] Print trailing newline when writing protobufs to end of command. When printing protobufs as JSON, we were not printing a trailing newline, which is confusing and leads to bad command-line UX. Print a newline in all commands. BUG=b:331291398 TEST=make test Change-Id: I896b76aa91554576940cd57fee9b7daaac7fb39e Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/5465118 Commit-Queue: Gregory Nisbet <gregorynisbet@google.com> Reviewed-by: Anushruth Sasivehalli <anushruth@chromium.org> Cr-Commit-Position: refs/heads/main@{#64666}
Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.