Google Git
Sign in
chromium / infra / infra / 0d05445c4bd2fd3ff139fad6fde318c3650a5b11
commit0d05445c4bd2fd3ff139fad6fde318c3650a5b11[log] [tgz]
authorJard Loucks <jaredloucks@google.com>Thu Oct 31 16:36:04 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Oct 31 16:36:04 2024
tree5046f227d46ac07aa56aaf92d660749b0ab5dbcd
parentf22bbbf9f019d2f5999da5c96ba523f440432caa [diff]
Reland "ctpv2: remove parentID"

This reverts commit ef16e72c03d82dfc3ea73b52df15ed7a48a52452.

Reason for revert: still broken apparently

Original change's description:
> Revert "ctpv2: remove parentID"
>
> This reverts commit 48b412e10d4a08d41564d84fcb01ea4b543e9baf.
>
> Reason for revert: no longer needed
>
> Original change's description:
> > ctpv2: remove parentID
> >
> > BUG=b:376428233
> > TEST=None
> >
> > Change-Id: If3722d8850ba5f45dfe2ce54d0c18e7b9c1de1da
> > Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/5979800
> > Auto-Submit: Julio Hurtado <juahurta@google.com>
> > Reviewed-by: Azizur Rahman <azrahman@google.com>
> > Commit-Queue: Azizur Rahman <azrahman@google.com>
> > Cr-Commit-Position: refs/heads/main@{#69500}
>
> Bug: b:376428233
> Change-Id: Idd2c0f46f571611f1dc468c2554e3bb51186d565
> Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/5980768
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Jard Loucks <jaredloucks@google.com>
> Cr-Commit-Position: refs/heads/main@{#69528}

Bug: b:376428233
Change-Id: Iac6e5620b94ab23d5dace6aa69d93ce1371fcc59
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/5983283
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jard Loucks <jaredloucks@google.com>
Cr-Commit-Position: refs/heads/main@{#69531}
1 file changed
tree: 5046f227d46ac07aa56aaf92d660749b0ab5dbcd
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. crdx/
  8. doc/
  9. docker/
  10. go/
  11. infra/
  12. node/
  13. packages/
  14. python_pb2/
  15. rbe/
  16. recipes/
  17. test/
  18. utils/
  19. luci
  20. .gitallowed
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .style.yapf
  25. .vpython
  26. .vpython3
  27. .yapfignore
  28. codereview.settings
  29. CONTRIBUTING.md
  30. DEPS
  31. LICENSE
  32. navbar.md
  33. OWNERS
  34. PRESUBMIT.py
  35. README.md
  36. run.py
  37. test.py
  38. WATCHLISTS
  39. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.