Google Git
Sign in
chromium / infra / infra / 16e654e5a0353281e32c3876aa6ee13d04f54010
commit16e654e5a0353281e32c3876aa6ee13d04f54010[log] [tgz]
authorChan Li <chanli@chromium.org>Mon Jan 14 23:04:28 2019
committerCommit Bot <commit-bot@chromium.org>Mon Jan 14 23:04:28 2019
treec9bd80db5ad2e3fe753138a62f102f2a5b43d608
parente7f7c2a95213b414768d17a0ae5cf5625e5146fb [diff]
Revert "[Findit] Resume filing bugs for retry_with_patch flakes as well."

This reverts commit 26a1ad59d316419b96a98ecfd87dfe4ccb8a6513.

Reason for revert: there are still too many bugs. revert this for now until we can have more inclusive flake grouping conditions.

Original change's description:
> [Findit] Resume filing bugs for retry_with_patch flakes as well.
> 
> Bug: 896006
> Change-Id: Ieae5286605a0cc823542056416c96501f86021e5
> Reviewed-on: https://chromium-review.googlesource.com/c/1406420
> Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
> Commit-Queue: Chan Li <chanli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#19933}

TBR=stgao@chromium.org,chanli@chromium.org,liaoyuke@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 896006
Change-Id: I9f57e4020cfe9c840b0c4fee38865f2cbffe5bed
Reviewed-on: https://chromium-review.googlesource.com/c/1410182
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19969}
3 files changed
tree: c9bd80db5ad2e3fe753138a62f102f2a5b43d608
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. cipd/
  7. crdx/
  8. data/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. recipes/
  17. test/
  18. utils/
  19. .gitattributes
  20. .gitignore
  21. codereview.settings
  22. CONTRIBUTING.md
  23. DEPS
  24. LICENSE
  25. navbar.md
  26. OWNERS
  27. PRESUBMIT.py
  28. README.md
  29. run.py
  30. test.py
  31. WATCHLISTS
  32. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, integrate your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. More your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have init.py files in each directory of your module so Python recognizes it as a package.