commit | 2e4357edd05d25ea2837e834e2a2d7f593fcac62 | [log] [tgz] |
---|---|---|
author | Owen Rodley <orodley@chromium.org> | Mon Jan 18 05:20:57 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jan 18 05:20:57 2021 |
tree | 9f9fefbe059dc26ca64206ef0f790dd299a12829 | |
parent | b43c8efb2ffca6c373ece62a5debb4abcacf5809 [diff] |
Make dockerbuild dryrun Windows-compatible. 'true' is not an available binary on Windows. Emulate it by directly returning a 0 status code and no stdout. Bug: 1144965 Change-Id: I6d0aba333f15b8a92ea2cad58d881b996d4814dd Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2631721 Commit-Queue: Owen Rodley <orodley@chromium.org> Commit-Queue: Brian Ryner <bryner@google.com> Auto-Submit: Owen Rodley <orodley@chromium.org> Reviewed-by: Brian Ryner <bryner@google.com> Cr-Commit-Position: refs/heads/master@{#37716}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.