Google Git
Sign in
chromium / infra / infra / 2e4df04be63362139fb36aeafd42b93afb6a8620
commit2e4df04be63362139fb36aeafd42b93afb6a8620[log] [tgz]
authorchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>Wed Apr 12 02:28:26 2023
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 12 02:28:26 2023
treee40df5f6150cb05abfbed0a4915bbea47ba51ecb
parent9b9c74e56d933fe5baa213fee24f1cc23e498ab3 [diff]
Roll luci-go from 28de2d6b1a05 to a8dd1ed931aa (1 revision)

https://chromium.googlesource.com/infra/luci/luci-go.git/+log/28de2d6b1a05..a8dd1ed931aa

2023-04-12 weiweilin@google.com [milo] fix search query not preserved when redirecting short build link

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/luci-go-infra-autoroll
Please CC iannucci@google.com,luci-eng@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: iannucci@google.com
Change-Id: I644e0d9e10f5ee1671ec3c067d662bc2626151e1
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/4415848
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#56058}
1 file changed
tree: e40df5f6150cb05abfbed0a4915bbea47ba51ecb
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. crdx/
  8. doc/
  9. docker/
  10. go/
  11. infra/
  12. node/
  13. packages/
  14. python_pb2/
  15. recipes/
  16. test/
  17. utils/
  18. .gitallowed
  19. .gitattributes
  20. .gitignore
  21. .style.yapf
  22. .vpython
  23. .vpython3
  24. .yapfignore
  25. codereview.settings
  26. CONTRIBUTING.md
  27. DEPS
  28. LICENSE
  29. navbar.md
  30. OWNERS
  31. PRESUBMIT.py
  32. README.md
  33. run.py
  34. test.py
  35. WATCHLISTS
  36. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.