commit | 3fb092bad88f107c3edb8b3fc34ee519880b8a8a | [log] [tgz] |
---|---|---|
author | Kevin Weng <kweng@google.com> | Sat Mar 06 01:36:14 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Mar 06 01:36:14 2021 |
tree | 95607659fe7ff97e0b695bdd69d84046d429c030 | |
parent | 8965cdc89ff9727d5bfe65ada2e099ababa11e10 [diff] |
[🚝] Hotfix for dequeueing email notification tasks when old_owner_id=None Bug: monorail:9167 Change-Id: I8b293f237775c54938072521dcf720ac5e65979f Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2739446 Auto-Submit: Kevin Weng <kweng@google.com> Reviewed-by: Andy Perelson <ajp@chromium.org> Commit-Queue: Kevin Weng <kweng@google.com> Cr-Commit-Position: refs/heads/master@{#39095}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.