Google Git
Sign in
chromium / infra / infra / 66c1a45df054485a8ea5c56c6a771c21ddc98b49
commit66c1a45df054485a8ea5c56c6a771c21ddc98b49[log] [tgz]
authorMichael Moss <mmoss@google.com>Fri May 24 21:48:35 2019
committerCommit Bot <commit-bot@chromium.org>Fri May 24 21:48:35 2019
treea6f51d54d32119272532f575329ab7212a4130ac
parent6adee02725953521c00622c3122651d67cea173b [diff]
Fix error when fetching new repo commits.

This can be reproduced by running recipe_bundler with a clean workdir:
  recipe_bundler bundle
    -workdir /tmp/workdir
    -r example.com/repo/name=FETCH_HEAD,refs/heads/master

which fails the initial example.com/repo/name fetch with:
  fatal: Refusing to fetch into current branch refs/heads/master of
  non-bare repository

This is a problem here because refspec=refs/heads/master, and that's the
default branch of a newly initialized checkout, but it could have the
same issue even for other refspecs if it reuses an existing checkout
where a previous run left "current branch" == refspec.

R=iannucci@google.com, tandrii@google.com

Change-Id: Ifd39cbe304573dd84726f3b797f018b146e3cb5e
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/1629307
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#23225}
1 file changed
tree: a6f51d54d32119272532f575329ab7212a4130ac
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. cipd/
  7. crdx/
  8. data/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. recipes/
  17. test/
  18. utils/
  19. .gitattributes
  20. .gitignore
  21. codereview.settings
  22. CONTRIBUTING.md
  23. DEPS
  24. LICENSE
  25. navbar.md
  26. OWNERS
  27. PRESUBMIT.py
  28. README.md
  29. run.py
  30. test.py
  31. WATCHLISTS
  32. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, integrate your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. More your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have init.py files in each directory of your module so Python recognizes it as a package.