commit	6d756cdeedf8c7c9a66530cf2a97acc6d510fc86	[log] [tgz]
author	Fumitoshi Ukai <ukai@google.com>	Mon Jan 20 03:03:31 2025
committer	LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>	Mon Jan 20 03:03:31 2025
tree	d5593460db7f72ec7f5c1fe02c426499c3da332b
parent	df3c41acb6eb9cf6a5906cee8783f2a1878d3944 [diff]

Revert "Add go lints to our presubmits."

This reverts commit 84c39dc66c7d22fd8a38ed3a3dfe3e186c4c014f.

Reason for revert: 
```
ukai@ukai ...infra/build/siso % git cl upload
Found change with 1 commit...
Running presubmit upload checks ...
** Presubmit ERRORS: 1 **
Evaluation of CheckChangeOnUpload failed: '<' not supported between instances of 'GitAffectedFile' and 'GitAffectedFile', Traceback (most recent call last):
  File "/usr/local/google/home/ukai/depot_tools/presubmit_support.py", line 1836, in _run_check_function
    result = eval(function_name + '(*__args)', context)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 1, in <module>
  File "/usr/local/google/home/ukai/src/infra/infra/PRESUBMIT.py", line 473, in CheckChangeOnUpload
    output = CommonChecks(input_api, output_api)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/google/home/ukai/src/infra/infra/PRESUBMIT.py", line 428, in CommonChecks
    output, tests = GoChecks(input_api, output_api)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/google/home/ukai/src/infra/infra/PRESUBMIT.py", line 400, in GoChecks
    tests = GoCheckers(input_api, output_api)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/google/home/ukai/src/infra/infra/PRESUBMIT.py", line 124, in GoCheckers
    affected_files = sorted([
                     ^^^^^^^^
TypeError: '<' not supported between instances of 'GitAffectedFile' and 'GitAffectedFile'


Presubmit checks took 1.3s to calculate.
There were presubmit errors.
```

Original change's description:
> Add go lints to our presubmits.
>
> We run golangci-lint on all changed packages now.
>
> Bug: 40944810
> Change-Id: Ied2f76c8b561e5e312b080f48208397fdc751fea
> Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/6038582
> Auto-Submit: Matt Stark <msta@google.com>
> Reviewed-by: Philipp Wollermann <philwo@google.com>
> Commit-Queue: Matt Stark <msta@google.com>
> Reviewed-by: Junji Watanabe <jwata@google.com>
> Reviewed-by: Fumitoshi Ukai <ukai@google.com>
> Cr-Commit-Position: refs/heads/main@{#71041}

Bug: 40944810
Change-Id: I0f9f5b3d0f87a32171e6ccaf8acd1cffd4c6a2c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/6184875
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Matt Stark <msta@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#71045}

2 files changed

tree: d5593460db7f72ec7f5c1fe02c426499c3da332b

README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
test.py: multi-purpose script to run tests.
packages/infra_libs/: generally useful functions and classes
infra/services/: standalone programs intended to be run as daemons.
infra/tools: command-line tools, intended to be run by developers.
appengine/: many Chrome-infra-managed AppEngine applications.
infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

bootstrap/: utilities to set up a proper Python virtual environment.
utils/: purpose? utils?
Need to bump infra/deployed to pick up changes?
- git push origin <updated hash>:deployed
- mail chrome-troopers@, include:
  - previously deployed hash (for quick rollback)
  - the hash you just pushed
  - the list of CLs that made this push necessary
  - the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.