commit | 86afde8bddaefce47381b7cc4638b36717803d3a | [log] [tgz] |
---|---|---|
author | chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> | Mon Apr 06 22:08:37 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Apr 06 22:08:37 2020 |
tree | 1521b673b8bc7ee1aac9aadb8ef1dc91661e2d53 | |
parent | cad067d4a8818168b9cbddc366473d5f922b1ff8 [diff] |
Roll infra/go/src/go.chromium.org/luci b94d5b70cf29..7ac4bfbe5a28 (1 commits) https://chromium.googlesource.com/infra/luci/luci-go.git/+log/b94d5b70cf29..7ac4bfbe5a28 git log b94d5b70cf29..7ac4bfbe5a28 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 vadimsh@chromium.org [lucicfg] Force kwargs for optional parameters in validators. Created with: gclient setdep -r infra/go/src/go.chromium.org/luci@7ac4bfbe5a28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/luci-go-infra-autoroll Please CC tandrii+infra-roll@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: tandrii+infra-roll@chromium.org Change-Id: I3e5dec07f3a802c188830cf94e0fd8b460791b70 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2138069 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#30339}
Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, integrate your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.