Google Git
Sign in
chromium / infra / infra / 8771dec6527f07954301056d713538bdb64517ce
commit8771dec6527f07954301056d713538bdb64517ce[log] [tgz]
authorGreg NISBET <gregorynisbet@google.com>Mon Jul 25 23:21:37 2022
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jul 25 23:21:37 2022
tree5a21862391f3a30e7227cb2f3b667ed1374d39bf
parent6a4e595cbd6036d6ae3e2719cc835fba61aa30f8 [diff]
[crosadm] Remove RolloutPermille field.

The RolloutPermille field is deprecated in favor of ProdPermille and LatestPermille.
Once the Paris migration is complete, the non-deprecated fields will still exist and
will be used to control how much of the prod traffic goes to the canary "latest" vs
prod "prod".

BUG=b:215550098
TEST=make test

Change-Id: Ic3f6cf5fba4747f0be8e320679af3384033ce889
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/3782209
Reviewed-by: Gowri Denduluri <gowriden@google.com>
Commit-Queue: Gregory Nisbet <gregorynisbet@google.com>
Cr-Commit-Position: refs/heads/main@{#50547}
2 files changed
tree: 5a21862391f3a30e7227cb2f3b667ed1374d39bf
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitallowed
  21. .gitattributes
  22. .gitignore
  23. .style.yapf
  24. .vpython
  25. .vpython3
  26. .yapfignore
  27. codereview.settings
  28. CONTRIBUTING.md
  29. DEPS
  30. LICENSE
  31. navbar.md
  32. OWNERS
  33. PRESUBMIT.py
  34. README.md
  35. run.py
  36. test.py
  37. WATCHLISTS
  38. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.