Google Git
Sign in
chromium / infra / infra / 8d31987929c128be22bfc801f2e5d4d0502891b1
commit8d31987929c128be22bfc801f2e5d4d0502891b1[log] [tgz]
authorQuinten Yearsley <qyearsley@chromium.org>Wed Jul 20 18:06:10 2022
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 20 18:06:10 2022
tree0d80340e182067f383ea9b6d9d4bef65d6d946cf
parentd7011a2d032f6973e0a86b266ffcf1e0b84b5b7b [diff]
tricium spellchecker: Add "patten" to ignorelist

This is a personal name and shouldn't be flagged.

Bug: 1344879
Change-Id: I06b800d86f9928d23688147c6ee0ed8136f4c8ad
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/3778179
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Auto-Submit: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Cr-Commit-Position: refs/heads/main@{#50424}
1 file changed
tree: 0d80340e182067f383ea9b6d9d4bef65d6d946cf
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitallowed
  21. .gitattributes
  22. .gitignore
  23. .style.yapf
  24. .vpython
  25. .vpython3
  26. .yapfignore
  27. codereview.settings
  28. CONTRIBUTING.md
  29. DEPS
  30. LICENSE
  31. navbar.md
  32. OWNERS
  33. PRESUBMIT.py
  34. README.md
  35. run.py
  36. test.py
  37. WATCHLISTS
  38. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.