Google Git
Sign in
chromium / infra / infra / b00958569d9b6daa97b77ca49a381b807d5c206d
commitb00958569d9b6daa97b77ca49a381b807d5c206d[log] [tgz]
authorChan <chanli@chromium.org>Sat Sep 15 05:35:21 2018
committerCommit Bot <commit-bot@chromium.org>Sat Sep 15 05:35:21 2018
tree8991176aa244eacb4c6af18be96d6cdacfc2b6ca
parent33e77d13e54b10dab09894b7f90393c72ca353b5 [diff]
[Findit] Flake Detedtion: Small UI polishments

In this CL, the changes on the UI are:
1. Fixed the 'no Login' issue on a flake page
2. Moved the table header of occurences out of groups so it can be shared by all groups
3. Style changes on the occurrences tables and ranked flakes table
4. Remove scrollbar from the occurrences tables
5. Add scrlollbar to the ranked flakes page

Bug: 880649
Change-Id: Icceaa204134f61eb82343711d3fd2a00a7b97dfb
Reviewed-on: https://chromium-review.googlesource.com/1227415
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17631}
6 files changed
tree: 8991176aa244eacb4c6af18be96d6cdacfc2b6ca
  1. appengine/
  2. appengine_module/
  3. bootstrap/
  4. build/
  5. cipd/
  6. crdx/
  7. data/
  8. doc/
  9. docker/
  10. glyco/
  11. go/
  12. infra/
  13. infra_libs/
  14. node/
  15. packages/
  16. recipes/
  17. test/
  18. third_party_packages/
  19. utils/
  20. .gitattributes
  21. .gitignore
  22. codereview.settings
  23. CONTRIBUTING.md
  24. DEPS
  25. LICENSE
  26. navbar.md
  27. OWNERS
  28. PRESUBMIT.py
  29. README.md
  30. roll-deps.py
  31. run.py
  32. test.py
  33. WATCHLISTS
  34. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, integrate your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. More your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have init.py files in each directory of your module so Python recognizes it as a package.