Google Git
Sign in
chromium / infra / infra / cb6672c6ee6d8fe3be1b58de968f87685d90baaf
commitcb6672c6ee6d8fe3be1b58de968f87685d90baaf[log] [tgz]
authorQuinten Yearsley <qyearsley@chromium.org>Wed Feb 20 17:47:04 2019
committerCommit Bot <commit-bot@chromium.org>Wed Feb 20 17:47:04 2019
tree2cf6ff57c167918575e17a445583f92f78c783bb
parent226883667d355dd18ef24b3c1b6d50767f99f603 [diff]
[tricium] Add logging when fetching buildbucket builds

Purpose: debugging

Background: Recently Julie enabled recipe-based tricium
runs for tricium-prod, which appear to be working up until
the point when tricium fetches the output. The output is in
the "tricium" field of the output properties.

This output had been previously successfully fetched, but
now it appears that

  `build.GetOutput().GetProperties().GetFields()["tricium"].GetStringValue()`

is empty string, even though on milo there does appear to be a
"tricium" field in the output properties.

Bug: 931768
Change-Id: Ida185dca732781e1f0ab777e11ecf24d55f4247f
Reviewed-on: https://chromium-review.googlesource.com/c/1478013
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20776}
1 file changed
tree: 2cf6ff57c167918575e17a445583f92f78c783bb
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. cipd/
  7. crdx/
  8. data/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. recipes/
  17. test/
  18. utils/
  19. .gitattributes
  20. .gitignore
  21. codereview.settings
  22. CONTRIBUTING.md
  23. DEPS
  24. LICENSE
  25. navbar.md
  26. OWNERS
  27. PRESUBMIT.py
  28. README.md
  29. run.py
  30. test.py
  31. WATCHLISTS
  32. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, integrate your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. More your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have init.py files in each directory of your module so Python recognizes it as a package.