commit | deb51ebb348fb9c17d2f719a7b5160856dcaf6e0 | [log] [tgz] |
---|---|---|
author | Quang Minh Tuan Nguyen <nqmtuan@google.com> | Wed Apr 14 21:41:01 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 14 21:41:01 2021 |
tree | b54a4d28dee14536fbff1d09f14e9694aa6323bb | |
parent | cd6cbf248f1df44e0a06af0d7dcbc8121fc898d0 [diff] |
[Findit] Change master to main in GetClDetails The last time Findit was successful in creating a revert CL is on April 5: https://chromium-review.googlesource.com/c/chromium/src/+/2805257. Looking at the log, it seems Findit failed to query for the CL details: https://screenshot.googleplex.com/5EK9Pv5h6FNM2oS. I suspect it may have something to do with the master -> main migration. Bug: 1198825 Change-Id: I8cf0f3a066260cc711181352d8ae7b4491e2afbd Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2823198 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Quang Minh Tuan Nguyen <nqmtuan@google.com> Cr-Commit-Position: refs/heads/master@{#40168}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.