Google Git
Sign in
chromium / infra / infra / e27936ef82d33a5f286e1f2f22817aa682f79e90
commite27936ef82d33a5f286e1f2f22817aa682f79e90[log] [tgz]
authorJason Robbins <jrobbins@chromium.org>Thu Jun 07 23:33:46 2018
committerCommit Bot <commit-bot@chromium.org>Thu Jun 07 23:33:46 2018
tree606ed0ea662fd5b860df4443ae85f4b6ae32d5d8
parent4a543064ae2f35f9c22136bb8e0270d84a440afe [diff]
[Monorail] Prevent request inflation via groupby=.

R=seanmccullough@chromium.org

Bug: b/109802037
Change-Id: I93cce0c79e4767a89cee173f1d4e6148d2a5b45b
Reviewed-on: https://chromium-review.googlesource.com/1092030
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Jason Robbins <jrobbins@chromium.org>
4 files changed
tree: 606ed0ea662fd5b860df4443ae85f4b6ae32d5d8
  1. appengine/
  2. appengine_module/
  3. bootstrap/
  4. build/
  5. cipd/
  6. crdx/
  7. data/
  8. doc/
  9. docker/
  10. glyco/
  11. go/
  12. infra/
  13. infra_libs/
  14. node/
  15. packages/
  16. recipes/
  17. test/
  18. utils/
  19. .gitattributes
  20. .gitignore
  21. codereview.settings
  22. CONTRIBUTING.md
  23. DEPS
  24. LICENSE
  25. navbar.md
  26. OWNERS
  27. PRESUBMIT.py
  28. README.md
  29. roll-deps.py
  30. run.py
  31. test.py
  32. WATCHLISTS
  33. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, integrate your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. More your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have init.py files in each directory of your module so Python recognizes it as a package.