Google Git
Sign in
chromium / infra / infra / master
commit09b0778eeacbaa794e8c8cd308ec3d12ab143dd4[log] [tgz]
authorJunji Watanabe <jwata@google.com>Fri Apr 23 17:03:02 2021
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Apr 23 17:03:02 2021
tree456b44d77a0954734b4f4d4fa703476990187390
parent06669d6eb687e5129e43e8027a7666025ad5c246 [diff]
migrate all CrOS docker bots to use Python3

The bot build32-a1--build10-a1 has been running in Python3.
https://chromium-swarm.appspot.com/bot?id=build32-a1--build10-a1

This CL migrates all CrOS docker bots to use Python3 to run Swarming process.
https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=bot_config&c=os&c=status&d=asc&f=os%3AChromeOS&f=inside_docker%3A1&k=inside_docker&s=id

Bug: 1111688
Change-Id: I71b68ecaee269133e2582128d4381d109b03453c
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2847902
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#40361}
1 file changed
tree: 456b44d77a0954734b4f4d4fa703476990187390
  1. .gitattributes
  2. .gitignore
  3. .style.yapf
  4. .yapfignore
  5. 3pp/
  6. CONTRIBUTING.md
  7. DEPS
  8. LICENSE
  9. OWNERS
  10. PRESUBMIT.py
  11. README.md
  12. WATCHLISTS
  13. WHITESPACE
  14. appengine/
  15. appengine_module/
  16. bootstrap/
  17. build/
  18. chromeperf/
  19. cipd/
  20. codereview.settings
  21. crdx/
  22. doc/
  23. docker/
  24. glyco/
  25. go/
  26. infra/
  27. navbar.md
  28. node/
  29. packages/
  30. python_pb2/
  31. recipes/
  32. run.py
  33. test.py
  34. test/
  35. utils/
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.