Google Git
Sign in
chromium / infra / infra / master
commitcf49cbd1acc4b77a0234d9e582e7284939c355f4[log] [tgz]
authorAviv Keshet <akeshet@chromium.org>Tue Jun 18 20:41:41 2019
committerCommit Bot <commit-bot@chromium.org>Tue Jun 18 20:41:41 2019
tree3e6f44abd3b25febcd74c944fa02fdf5575a3fc8
parenta226a5634bfb1e10e19e8d8c66e96a82fb6ef11f [diff]
qscheduler: shorten the batch construction time to 10ms

The 100ms batch construction time did succeed at forcing batches to
reach maximum size, but also reduced the app throughput observably. A
much shorter timeout is probably sufficient to force appengine to hand
over all the requests that it is willing to hand over.

BUG=974887
TEST=None

Change-Id: I464b68d82433daef0810b48caed0cc59d8eec1a4
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/1663735
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#23774}
1 file changed
tree: 3e6f44abd3b25febcd74c944fa02fdf5575a3fc8
  1. .gitattributes
  2. .gitignore
  3. 3pp/
  4. CONTRIBUTING.md
  5. DEPS
  6. LICENSE
  7. OWNERS
  8. PRESUBMIT.py
  9. README.md
  10. WATCHLISTS
  11. WHITESPACE
  12. appengine/
  13. appengine_module/
  14. bootstrap/
  15. build/
  16. cipd/
  17. codereview.settings
  18. crdx/
  19. data/
  20. doc/
  21. docker/
  22. glyco/
  23. go/
  24. infra/
  25. navbar.md
  26. node/
  27. packages/
  28. recipes/
  29. run.py
  30. test.py
  31. test/
  32. utils/
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, integrate your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. More your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have init.py files in each directory of your module so Python recognizes it as a package.