Google Git
Sign in
chromium / infra / infra / master
commit36809f9486cc4246142f92897b7e15f6564bd94f[log] [tgz]
authorPrakhar <pasthana@google.com>Sat May 30 08:38:59 2020
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat May 30 08:38:59 2020
treed0197b8ba51e65a28693c7aeaa70412b9d0dbf47
parent7bcb72985caa540e7bd8f8e58c3d1cf46a834133 [diff]
Change display of coverage report to distinguish b/w code with low(50-70%) and poor(<50%) coverage

Staging link: https://findit-for-me-staging.uc.r.appspot.com/p/chromium/coverage

Bug: 1072001
Change-Id: I0432a602671886ff44b7110cca0b054bbbc5e8db
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2220117
Commit-Queue: Prakhar Asthana <pasthana@google.com>
Auto-Submit: Prakhar Asthana <pasthana@google.com>
Reviewed-by: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#31948}
1 file changed
tree: d0197b8ba51e65a28693c7aeaa70412b9d0dbf47
  1. .gitattributes
  2. .gitignore
  3. .style.yapf
  4. .yapfignore
  5. 3pp/
  6. CONTRIBUTING.md
  7. DEPS
  8. LICENSE
  9. OWNERS
  10. PRESUBMIT.py
  11. README.md
  12. WATCHLISTS
  13. WHITESPACE
  14. appengine/
  15. appengine_module/
  16. bootstrap/
  17. build/
  18. cipd/
  19. codereview.settings
  20. crdx/
  21. doc/
  22. docker/
  23. glyco/
  24. go/
  25. infra/
  26. navbar.md
  27. node/
  28. packages/
  29. python_pb2/
  30. recipes/
  31. run.py
  32. test.py
  33. test/
  34. utils/
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.