Google Git
Sign in
chromium / infra / infra / refs/heads/cit
commit92dd3114c25983fb48594ea5eb70ecbe2c87a4fd[log] [tgz]
authorchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>Fri Aug 06 03:02:51 2021
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Aug 06 03:02:51 2021
tree94c349bdcfcfc7c266b793f8354af7f9bf5300c6
parent8aa1a323fc250997404799da52c567393176a5c0 [diff]
Roll luci-go from 1c5a9e74d7e9 to 89cea944a885 (1 revision)

https://chromium.googlesource.com/infra/luci/luci-go.git/+log/1c5a9e74d7e9..89cea944a885

2021-08-06 vadimsh@chromium.org [swarming] Refactor client integration test.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/luci-go-infra-autoroll
Please CC tandrii+infra-roll@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: tandrii+infra-roll@chromium.org
Change-Id: I9198b83bbce9e174eedb50c2e36df3442a1426d9
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/3076920
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#42944}
1 file changed
tree: 94c349bdcfcfc7c266b793f8354af7f9bf5300c6
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitallowed
  21. .gitattributes
  22. .gitignore
  23. .style.yapf
  24. .vpython
  25. .vpython3
  26. .yapfignore
  27. codereview.settings
  28. CONTRIBUTING.md
  29. DEPS
  30. LICENSE
  31. navbar.md
  32. OWNERS
  33. PRESUBMIT.py
  34. README.md
  35. run.py
  36. test.py
  37. WATCHLISTS
  38. WHITESPACE
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.