| commit | 043deeee59a8e1203b3350fb9d315b3d0d7db076 | [log] [tgz] |
|---|---|---|
| author | iannucci <iannucci@chromium.org> | Sat Dec 12 17:23:03 2015 |
| committer | Commit bot <commit-bot@chromium.org> | Sat Dec 12 17:23:03 2015 |
| tree | d6aa97b029bb418835f621b3affe649cb696f603 | |
| parent | c8ceb29058d5632b962bfdb96c34f59fb8a6ec98 [diff] |
Clean up PropertyLoadSaver interface. This removes GetMetaDefault and Problem from the interfaces, and makes GetPLS errors into panics, on the assumption that if you pass it a bad datatype, you can't really do anything about it without recompiling, and failing fast is better. This also fixes a bug where doing any operations on an invalid (non datastore- compatible) struct would return the unhelpful "unable to extract $kind" error. R=dnj@chromium.org, hinoka@chromium.org, martiniss@chromium.org, vadimsh@chromium.org BUG= Review URL: https://codereview.chromium.org/1516173002
designed for testing and extensibility
(but generally it should be pretty stableish).
go get -u github.com/luci/gae/...
See the godocs.
master contains the latest code.user.email and user.name are configured in git config.go get -u github.com/maruel/pre-commit-go/cmd/... && pcgRun the following to setup the code review tool and create your first review:
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" cd $GOROOT/github.com/luci/gae git new-branch work # or `git checkout -b work origin/master` if you like typing more. # hack hack git commit -a -m "This is awesome\nR=joe@example.com" # This will ask for your Google Account credentials. git cl upload -s # Wait for LGTM over email. # Check Commit Queue checkbox in Rietveld codereview site. # See it tested and landed automatically.
Use git cl help and git cl help <cmd> for more details.