Google Git
Sign in
chromium / infra / luci / gae / 31b3460980f3e048bb57f214952fb775aa21973f
commit31b3460980f3e048bb57f214952fb775aa21973f[log] [tgz]
authordnj <dnj@chromium.org>Wed Nov 02 02:09:42 2016
committerCommit bot <commit-bot@chromium.org>Wed Nov 02 02:09:42 2016
tree03244a4fdb7bbea895688bd49e8a5b61dc7925d3
parentcfd4c03f8de6f353360064aca2d2fcf517bedf8b [diff]
impl/prod: Make AEContext private.

AEContext is confusing and magical, as is evidenced by #63, exposing
impl/prod's internal structures and a lot of gritty and nuanced details about
how it manages AppEngine SDK Contexts.

Rather than direct users here, let's offer a clean break: users who want
to interact with the Google AppEngine SDK directly must explicitly create
their own Context for this using appengine.(Use|With)Context.
Internally, this is very efficient, as AppEngine retains Contexts bound
to requests in a map.

With this patch the division is clearer: luci/gae will not help you
access the raw AppEngine SDK, period.

BUG=None
TEST=local
  - `goapp test ./impl/prod`

Review-Url: https://codereview.chromium.org/2460473003
10 files changed
tree: 03244a4fdb7bbea895688bd49e8a5b61dc7925d3
  1. docs/
  2. filter/
  3. impl/
  4. infra/
  5. service/
  6. tools/
  7. .travis.yml
  8. AUTHORS
  9. codereview.settings
  10. CONTRIBUTORS
  11. doc.go
  12. LICENSE
  13. pre-commit-go.yml
  14. PRESUBMIT.py
  15. README.md
  16. symbols.go
README.md

gae: A Google AppEngine SDK wrapper

designed for testing and extensibility

THIS PACKAGE HAS NO API COMPATIBILITY GUARANTEES. USE UNPINNED AT YOUR OWN PERIL.

(but generally it should be pretty stableish).

GoDoc Build Status Coverage Status

Installing

go get -u github.com/luci/gae/...

Why/What/How

See the godocs.

Versioning

  • Branch master contains the latest code.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.
  • Install the pcg git hook: go get -u github.com/maruel/pre-commit-go/cmd/... && pcg

Run the following to setup the code review tool and create your first review:

git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"
cd $GOROOT/github.com/luci/gae
git new-branch work
# or `git checkout -b work origin/master` if you like typing more.

# hack hack

git commit -a -m "This is awesome\nR=joe@example.com"
# This will ask for your Google Account credentials.
git cl upload -s
# Wait for LGTM over email.
# Check Commit Queue checkbox in Rietveld codereview site.
# See it tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.