Annotate ErrInvalidKey.

The ErrInvalidKey error is annoying when encountered, becuase it
provides no context about why the key is invalid and can occur in some
obscure places (checkfilter, query finalization, implementations, etc.).

To address this, replace ErrInvalidKey with a test function,
IsErrInvalidKey. This will return true for any invalid key errors.
Replace instances of ErrInvalidKey with errors derived from
MakeErrInvalidKey, annotated with some context and useful information.

This should be relatively minor change upstream, since no audited code
actually checks for this error case.

BUG=None
TEST=unit

Review-Url: https://codereview.chromium.org/2620043002
9 files changed
tree: dca6a08a57fe83663d5573c9ade8c42773919940
  1. docs/
  2. filter/
  3. impl/
  4. infra/
  5. service/
  6. tools/
  7. .travis.yml
  8. AUTHORS
  9. codereview.settings
  10. CONTRIBUTORS
  11. doc.go
  12. LICENSE
  13. pre-commit-go.yml
  14. PRESUBMIT.py
  15. README.md
  16. symbols.go
README.md

gae: A Google AppEngine SDK wrapper

designed for testing and extensibility

THIS PACKAGE HAS NO API COMPATIBILITY GUARANTEES. USE UNPINNED AT YOUR OWN PERIL.

(but generally it should be pretty stableish).

GoDoc Build Status Coverage Status

Installing

go get -u github.com/luci/gae/...

Why/What/How

See the godocs.

Versioning

  • Branch master contains the latest code.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.
  • Install the pcg git hook: go get -u github.com/maruel/pre-commit-go/cmd/... && pcg

Run the following to setup the code review tool and create your first review:

git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"
cd $GOROOT/github.com/luci/gae
git new-branch work
# or `git checkout -b work origin/master` if you like typing more.

# hack hack

git commit -a -m "This is awesome\nR=joe@example.com"
# This will ask for your Google Account credentials.
git cl upload -s
# Wait for LGTM over email.
# Check Commit Queue checkbox in Rietveld codereview site.
# See it tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.