commit | 89a62d1eb8fedbc521ce133e731fb8770c54eed9 | [log] [tgz] |
---|---|---|
author | dnj <dnj@chromium.org> | Wed Jan 11 03:12:51 2017 |
committer | Commit bot <commit-bot@chromium.org> | Wed Jan 11 03:12:51 2017 |
tree | dca6a08a57fe83663d5573c9ade8c42773919940 | |
parent | 4735254e6dbfa13048893cc43ede87a4110f4b27 [diff] |
Annotate ErrInvalidKey. The ErrInvalidKey error is annoying when encountered, becuase it provides no context about why the key is invalid and can occur in some obscure places (checkfilter, query finalization, implementations, etc.). To address this, replace ErrInvalidKey with a test function, IsErrInvalidKey. This will return true for any invalid key errors. Replace instances of ErrInvalidKey with errors derived from MakeErrInvalidKey, annotated with some context and useful information. This should be relatively minor change upstream, since no audited code actually checks for this error case. BUG=None TEST=unit Review-Url: https://codereview.chromium.org/2620043002
designed for testing and extensibility
(but generally it should be pretty stableish).
go get -u github.com/luci/gae/...
See the godocs.
master
contains the latest code.user.email
and user.name
are configured in git config
.go get -u github.com/maruel/pre-commit-go/cmd/... && pcg
Run the following to setup the code review tool and create your first review:
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" cd $GOROOT/github.com/luci/gae git new-branch work # or `git checkout -b work origin/master` if you like typing more. # hack hack git commit -a -m "This is awesome\nR=joe@example.com" # This will ask for your Google Account credentials. git cl upload -s # Wait for LGTM over email. # Check Commit Queue checkbox in Rietveld codereview site. # See it tested and landed automatically.
Use git cl help
and git cl help <cmd>
for more details.